New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Vertical tabs active width fix #18940
fix: Vertical tabs active width fix #18940
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add tests to make sure this change works as expected?
Deploy preview for ant-design ready! Built with commit 893c0a0 |
Codecov Report
@@ Coverage Diff @@
## master #18940 +/- ##
==========================================
- Coverage 96.93% 96.92% -0.01%
==========================================
Files 281 281
Lines 7557 7554 -3
Branches 2068 2105 +37
==========================================
- Hits 7325 7322 -3
Misses 230 230
Partials 2 2
Continue to review full report at Codecov.
|
How about this solution. @dengfuping |
还有一个解决方案,取消 |
Fixed in #24552 |
🤔 This is a ...
🔗 Related issue link
#18652
💡 Background and solution
Background
tab active之后font-weight变成500,字体宽度会变宽0.17px (macOS chrome 76.0.3809.132),导致观察到tab “跳一下”。
solution
rc-tabs 为 tab 为 string 增加 attribute,antd 使用伪元素为其预留位置
📝 Changelog
☑️ Self Check before Merge