Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Put origin img size to fill the box #18990

Merged
merged 1 commit into from Sep 25, 2019

Conversation

@zombieJ
Copy link
Member

commented Sep 25, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #18989

💡 Background and solution

Default setting the img of file will not cut before:

Form
屏幕快照 2019-09-25 上午11 05 03

To
屏幕快照 2019-09-25 上午11 05 14

📝 Changelog

Language Changelog
🇺🇸 English 💄 Adjust Upload picture-card mode picture display style to fill the picture box.
🇨🇳 Chinese 💄 调整 Upload picture-card 模式下,图片展示样式为填充整个图片框。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@pr-triage pr-triage bot added the PR: unreviewed label Sep 25, 2019
@netlify

This comment has been minimized.

Copy link

commented Sep 25, 2019

Deploy preview for ant-design ready!

Built with commit e498480

https://deploy-preview-18990--ant-design.netlify.com

@afc163

This comment has been minimized.

Copy link
Member

commented Sep 25, 2019

/rebase

@github-actions github-actions bot force-pushed the upload branch from 3a98191 to e498480 Sep 25, 2019
@codecov

This comment has been minimized.

Copy link

commented Sep 25, 2019

Codecov Report

Merging #18990 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18990   +/-   ##
=======================================
  Coverage   96.93%   96.93%           
=======================================
  Files         281      281           
  Lines        7557     7557           
  Branches     2068     2110   +42     
=======================================
  Hits         7325     7325           
  Misses        230      230           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d7a87e...e498480. Read the comment docs.

@zombieJ zombieJ merged commit 5aa32a3 into master Sep 25, 2019
26 of 29 checks passed
26 of 29 checks passed
Header rules - ant-design No header rules processed
Details
LGTM analysis: JavaScript No code changes detected
Details
Pages changed - ant-design 228 new files uploaded
Details
License Compliance All checks passed.
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
buildsize No change
Details
bundlesize Total bundle size is 582.81KB/600KB (-null)
Details
ci/circleci: check_metadata Your tests passed on CircleCI!
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 6d7a87e...e498480
Details
codecov/project 96.93% remains the same compared to 6d7a87e
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected
@zombieJ zombieJ deleted the upload branch Sep 25, 2019
@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Sep 25, 2019
@ikobe ikobe referenced this pull request Sep 29, 2019
1 of 14 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.