New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: replace resizeObserver with rc-resize-observer
#19057
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add tests to make sure this change works as expected?
Deploy preview for ant-design ready! Built with commit f720130 |
Codecov Report
@@ Coverage Diff @@
## master #19057 +/- ##
==========================================
- Coverage 97.39% 97.38% -0.02%
==========================================
Files 281 280 -1
Lines 7559 7526 -33
Branches 2115 2109 -6
==========================================
- Hits 7362 7329 -33
Misses 196 196
Partials 1 1
Continue to review full report at Codecov.
|
@zombieJ, after this pull request I cannot pass multiple nodes as children to Affix. Only the first node gets rendered and getting a cryptic error in the console. This was working in 3.20.3:
Now, only homeButton gets rendered. |
@filipjnc , could you help to create an issue and add the reproduce? |
🤔 This is a ...