Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace resizeObserver with rc-resize-observer #19057

Merged
merged 3 commits into from Sep 29, 2019
Merged

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Sep 29, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@netlify
Copy link

netlify bot commented Sep 29, 2019

Deploy preview for ant-design ready!

Built with commit f720130

https://deploy-preview-19057--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Sep 29, 2019

Codecov Report

Merging #19057 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #19057      +/-   ##
==========================================
- Coverage   97.39%   97.38%   -0.02%     
==========================================
  Files         281      280       -1     
  Lines        7559     7526      -33     
  Branches     2115     2109       -6     
==========================================
- Hits         7362     7329      -33     
  Misses        196      196              
  Partials        1        1
Impacted Files Coverage Δ
components/affix/index.tsx 97.32% <ø> (ø) ⬆️
components/input/TextArea.tsx 96.36% <ø> (ø) ⬆️
components/typography/Base.tsx 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5aea71...f720130. Read the comment docs.

@zombieJ zombieJ merged commit e07bba9 into master Sep 29, 2019
@zombieJ zombieJ deleted the resize-deps branch September 29, 2019 09:56
ikobe-zz pushed a commit that referenced this pull request Sep 30, 2019
* ✅ increase upload test cov

* chore: replace resizeObserver with `rc-resize-observer` (#19057)

* replace resizeObserver with rc-resize-observer

* fix affix lint

* fix es lint

* changelog (#19056)

* Release 3.23.5
@filipjnc
Copy link

filipjnc commented Oct 7, 2019

@zombieJ, after this pull request I cannot pass multiple nodes as children to Affix. Only the first node gets rendered and getting a cryptic error in the console.

This was working in 3.20.3:

<Affix ref={navAffixRef} offsetBottom={10}>
    {homeButton}
    {showPrevButton && prevButton}
    {showNextButton && nextButton}
</Affix>

Now, only homeButton gets rendered.

@zombieJ
Copy link
Member Author

zombieJ commented Oct 8, 2019

@filipjnc , could you help to create an issue and add the reproduce?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants