QA: Button loading prop as object feature #19213
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![tests-checker[bot]](https://avatars.githubusercontent.com/in/17064?s=60&v=4){kind=small}
|
Deploy preview for ant-design ready! Built with commit 1e33f88 |
akaguny
changed the title
akaguny
changed the title
|
ci broken |
|
@afc163 test broken and it's success) |
afc163
reviewed
Dec 5, 2019
| wrapper.simulate('click'); | ||
| expect(wrapper.hasClass('ant-btn-loading')).toBe(false); | ||
| expect(wrapper.render().hasClass('ant-btn-loading')).toBe(true); |
There was a problem hiding this comment.
It should be false because we have a delayed loading. I think our loading prop of object type works correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃 This is a ...
馃敆 Related issue link
nothing
馃挕 Background and solution
When i explore ant components i
m find loading.delay prop in Button component, but it i think is not usefully. And i went to unit tests to explain how it works correctly. But now i don't lnow this. Im suggest to delete this api sometime.Help to explain pls.
If it`s really usefully i suggest to add usage example in next PR to ant. And i want improve unit-test because now without render i thing they is nit correct.
I make some example in codesandbox based on unit test wrapper component
https://codesandbox.io/embed/button-with-delay-loading-upyrs
馃摑 Changelog
鈽戯笍 Self Check before Merge