docs: add mentions component filterOption default #19241
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for ant-design ready! Built with commit 614b200 |
shaodahong
changed the title
Codecov Report
@@ Coverage Diff @@
## master #19241 +/- ##
=======================================
Coverage 97.78% 97.78%
=======================================
Files 282 282
Lines 7625 7625
Branches 2132 2132
=======================================
Hits 7456 7456
Misses 169 169
Continue to review full report at Codecov.
|
|
默认需要触发 filter |
|
加个默认值吧 |
shaodahong
changed the title
|
👌，代码那边是没动只是 prettier 对吧？ |
zombieJ
reviewed
Oct 16, 2019
| @@ -26,7 +26,7 @@ When need to mention someone or something. | |||
| | --- | --- | --- | --- | --- | | |||
| | autoFocus | Auto get focus when component mounted | boolean | `false` | 3.19.0 | | |||
| | defaultValue | Default value | string | - | 3.19.0 | | |||
| | filterOption | Customize filter option logic | false \| (input: string, option: OptionProps) => boolean | - | 3.19.0 | | |||
| | filterOption | Customize filter option logic | false \| (input: string, option: OptionProps) => boolean | `(input, { value }) => value.toLowerCase().indexOf(input.toLowerCase()) !== -1` | 3.19.0 | | |||
There was a problem hiding this comment.
这个太长了，也不是用户关心的。改成 Case Insensitive 吧
There was a problem hiding this comment.
不区分大小写感觉令人困惑，解释不了中文和拼音之间的联动性，至少实际项目中异步返回数据来说并不是字符的 indexOf，就和 GitHub 的 # 一样
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
Fixed #19235
💡 Background and solution
📝 Changelog
☑️ Self Check before Merge