Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade rc-tooltip lint fail #19408

Merged
merged 13 commits into from Dec 5, 2019
Merged

fix: upgrade rc-tooltip lint fail #19408

merged 13 commits into from Dec 5, 2019

Conversation

shaodahong
Copy link
Member

@shaodahong shaodahong commented Oct 24, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

Ref: #19179 (comment)

馃挕 Background and solution

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@netlify
Copy link

netlify bot commented Oct 24, 2019

Deploy preview for ant-design ready!

Built with commit f875313

https://deploy-preview-19408--ant-design.netlify.com

@buildsize
Copy link

buildsize bot commented Oct 24, 2019

File name Previous Size New Size Change
package-lock.json 973.67聽KB 971.5聽KB -2.17聽KB (0%)

@shaodahong shaodahong changed the title fix: upgrade rc-tooltip lint fail [WIP] fix: upgrade rc-tooltip lint fail Oct 24, 2019
@codecov
Copy link

codecov bot commented Oct 25, 2019

Codecov Report

Merging #19408 into 4.0-prepare will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##           4.0-prepare   #19408   +/-   ##
============================================
  Coverage        97.56%   97.56%           
============================================
  Files              294      294           
  Lines             7237     7237           
  Branches          1992     1992           
============================================
  Hits              7061     7061           
  Misses             176      176
Impacted Files Coverage 螖
components/popover/index.tsx 100% <酶> (酶) 猬嗭笍
components/tooltip/index.tsx 96.62% <100%> (酶) 猬嗭笍
components/tooltip/placements.tsx 85% <100%> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 6a70d31...f875313. Read the comment docs.

@zombieJ
Copy link
Member

zombieJ commented Oct 25, 2019

+ rc-tooltip@4.0.0-alpha.1

@shaodahong
Copy link
Member Author

wait to upgrade rc-trigger finish, because of use rc-trigger typescript type

@shaodahong shaodahong changed the title [WIP] fix: upgrade rc-tooltip lint fail fix: upgrade rc-tooltip lint fail Nov 16, 2019
@zombieJ
Copy link
Member

zombieJ commented Nov 17, 2019

+ rc-trigger@4.0.0-alpha.6

@shaodahong
Copy link
Member Author

shaodahong commented Nov 18, 2019

it('inlineCollapsed should works well when specify a not existed default openKeys', () => {

@zombieJ
this test is too weird, inline mode but expect vertical?

expect(
  wrapper
    .find('.ant-menu-submenu')
    .at(0)
    .hasClass('ant-menu-submenu-vertical'),
).toBe(true);

@zombieJ
Copy link
Member

zombieJ commented Nov 18, 2019

@shaodahong
Copy link
Member Author

inlineCollapsed is this case: https://ant.design/components/menu-cn/#components-menu-demo-inline-collapsed

yep, but class is ant-menu-submenu-inline

@shaodahong
Copy link
Member Author

it('inlineCollapsed should works well when specify a not existed default openKeys', () => {

this test is too weird, inline mode but expect vertical?

expect(
  wrapper
    .find('.ant-menu-submenu')
    .at(0)
    .hasClass('ant-menu-submenu-vertical'),
).toBe(true);

may check below test, but I don't know why in this test to expect

@zombieJ
Copy link
Member

zombieJ commented Nov 19, 2019

rc-menu has complex logic and some dirty code which may hard to understand about className, but it should keep these className since Menu with mixed status like inline & collapsed will both have inline & popup related className. And menu style file both use then to handle some mixed style.

@shaodahong
Copy link
Member Author

/rebase

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 30, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f875313:

Sandbox Source
antd reproduction template Configuration

@shaodahong
Copy link
Member Author

shaodahong commented Dec 2, 2019

@chenshuai2144 rc-calendar 10.0.0-alpha.1 version cause typescript lint fail https://circleci.com/gh/ant-design/ant-design/136908?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link, can you resolve it? thanks

Open a new PR and upgrade rc-calendar, and check some UI or CI

@shaodahong shaodahong merged commit 114fdd9 into ant-design:4.0-prepare Dec 5, 2019
@shaodahong shaodahong deleted the fix-rc-tooltip branch December 5, 2019 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants