Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Drawer content overflow when placement is top or bottom #19506

Merged
merged 3 commits into from Nov 6, 2019
Merged

fix: Drawer content overflow when placement is top or bottom #19506

merged 3 commits into from Nov 6, 2019

Conversation

shaodahong
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

Fixed #19454

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Drawer content overflow when placement prop is top or bottom
🇨🇳 Chinese 修复 Drawer 当 placement 属性为 topbottom 时内容溢出

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@netlify
Copy link

netlify bot commented Oct 31, 2019

Deploy preview for ant-design ready!

Built with commit 93bcd2a

https://deploy-preview-19506--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Oct 31, 2019

Codecov Report

Merging #19506 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #19506      +/-   ##
==========================================
- Coverage    97.8%    97.8%   -0.01%     
==========================================
  Files         284      284              
  Lines        7698     7696       -2     
  Branches     2116     2160      +44     
==========================================
- Hits         7529     7527       -2     
  Misses        169      169
Impacted Files Coverage Δ
components/drawer/index.tsx 98.68% <100%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48763bf...93bcd2a. Read the comment docs.

@afc163 afc163 requested a review from jljsj33 October 31, 2019 11:50
@jljsj33
Copy link
Member

jljsj33 commented Nov 1, 2019

https://github.com/react-component/drawer/blob/master/assets/index.less#L31

参照 rc-drawer 加在 content 里吧;

@shaodahong
Copy link
Member Author

@jljsj33 有一点很怪异, 如果可以滚动, 我滚动一段距离关闭再重新打开, 滚动距离还是上次的, 这个是不是应该优化

@jljsj33
Copy link
Member

jljsj33 commented Nov 2, 2019

不用忧化,, antd 有关闭后清除子级内容的。。。

@yoyo837
Copy link
Contributor

yoyo837 commented Nov 6, 2019

hello, rebase

@shaodahong
Copy link
Member Author

/rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drawer: overflowed content cannot be hidden when placement is top
3 participants