Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Drawer content overflow when placement is top or bottom #19506

Merged

Conversation

@shaodahong
Copy link
Collaborator

shaodahong commented Oct 31, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

Fixed #19454

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Drawer content overflow when placement prop is top or bottom
🇨🇳 Chinese 修复 Drawer 当 placement 属性为 top 或 bottom 时内容溢出

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@pr-triage pr-triage bot added the PR: unreviewed label Oct 31, 2019
@netlify

This comment has been minimized.

Copy link

netlify bot commented Oct 31, 2019

Deploy preview for ant-design ready!

Built with commit 93bcd2a

https://deploy-preview-19506--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

codecov bot commented Oct 31, 2019

Codecov Report

Merging #19506 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #19506      +/-   ##
==========================================
- Coverage    97.8%    97.8%   -0.01%     
==========================================
  Files         284      284              
  Lines        7698     7696       -2     
  Branches     2116     2160      +44     
==========================================
- Hits         7529     7527       -2     
  Misses        169      169
Impacted Files Coverage Δ
components/drawer/index.tsx 98.68% <100%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48763bf...93bcd2a. Read the comment docs.

@afc163 afc163 requested a review from jljsj33 Oct 31, 2019
@jljsj33

This comment has been minimized.

Copy link
Member

jljsj33 commented Nov 1, 2019

https://github.com/react-component/drawer/blob/master/assets/index.less#L31

参照 rc-drawer 加在 content 里吧;

@jljsj33

This comment has been minimized.

Copy link
Member

jljsj33 commented Nov 1, 2019

@shaodahong

This comment has been minimized.

Copy link
Collaborator Author

shaodahong commented Nov 1, 2019

@jljsj33 有一点很怪异, 如果可以滚动, 我滚动一段距离关闭再重新打开, 滚动距离还是上次的, 这个是不是应该优化

@jljsj33
jljsj33 approved these changes Nov 2, 2019
@jljsj33

This comment has been minimized.

Copy link
Member

jljsj33 commented Nov 2, 2019

不用忧化,, antd 有关闭后清除子级内容的。。。

@yoyo837

This comment has been minimized.

Copy link
Collaborator

yoyo837 commented Nov 6, 2019

hello, rebase

@shaodahong

This comment has been minimized.

Copy link
Collaborator Author

shaodahong commented Nov 6, 2019

/rebase

@shaodahong shaodahong force-pushed the shaodahong:fix-drawer-content-overflow branch from e55971f to 93bcd2a Nov 6, 2019
@shaodahong shaodahong merged commit 4ded5e6 into ant-design:master Nov 6, 2019
26 checks passed
26 checks passed
Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 218 new files uploaded
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
buildsize No change
Details
ci/circleci: check_metadata Your tests passed on CircleCI!
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 97.8%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +2.19% compared to 48763bf
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected
@shaodahong shaodahong deleted the shaodahong:fix-drawer-content-overflow branch Nov 6, 2019
@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Nov 6, 2019
@yoyo837 yoyo837 mentioned this pull request Nov 15, 2019
0 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.