Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add XHR #19535

Closed
wants to merge 10 commits into from
Closed

Add XHR #19535

wants to merge 10 commits into from

Conversation

hahmadia
Copy link
Contributor

@hahmadia hahmadia commented Nov 3, 2019 •
edited by markdownify bot

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/cascader/index.en-US.md
View rendered components/cascader/index.zh-CN.md
View rendered components/input/demo/textarea-resize.md
View rendered components/slider/demo/vertical.md
View rendered components/table/demo/fixed-columns-header.md
View rendered components/table/demo/fixed-columns.md
View rendered components/table/demo/fixed-header.md
View rendered components/tree-select/demo/async.md
View rendered components/tree-select/demo/basic.md
View rendered components/tree-select/demo/checkable.md
View rendered components/tree-select/demo/multiple.md
View rendered components/tree-select/demo/suffix.md
View rendered components/tree-select/demo/treeData.md
View rendered components/upload/index.en-US.md

hi-rustin and others added 10 commits October 29, 2019 10:08
@hi-rustin @afc163
fix: modify textarea resize demo defaultValue to english (ant-design#…
fdf38f4 
…19348)

* modify textarea defaultValue to english

* update test snapshots
@broder @afc163
docs: Responsive fixes for examples pages (ant-design#19448)
654a675 
* Remove fixed width from cascader examples

* Replace fixed vertical slider example height with clearfix div

* Replace fixed width on TreeSelect examples with percentage width

* Update test snapshots

* Use inline-block rather than float left for vertical slider example
@NightFox7 @afc163
Fix defaultPickerValue in WeekPicker (ant-design#19141)
13995bf
@afc163
🐛 Fix DatePicker throw onEsc error
2ee2cc3 
close ant-design#19461
@wangweijun0418 @afc163
Fix Menu menu collapsed in Chrome (ant-design#19476)
d99d90b 
* Update index.less

修复margin重合样式问题，（次问题造成menu组件下拉不顺畅）

* Update index.less

解决margin重合问题，overflow方式会有副作用，采用padding解决margin重合现象。
@chnliquan @afc163
fix(Upload): add interface field (ant-design#19485) (ant-design#19496)
593cfe8
@jacklee814 @afc163
fix: remove the selected padding right when use allow clear (ant-desi…
82aa3cd 
…gn#19510)
@afc163
docs: improve table demo description
92caa2d
@MrHeer @shaodahong
fix: table does not automatically scroll to the top when change page …
3d8b9df 
…size (ant-design#19465)

* 🐛 (Table): fix scrollToFirstRow

fix table does not automatically scroll to the top when change page size
close ant-design#19464

* ✅ (Table): add test case for scrollToFirstRow

* 👌 (Table): change Trigger to .ant-select

Co-Authored-By: 骗你是小猫咪 <darryshaw@gmail.com>
@hahmadia
Gets the XMLHttpRequest Object in Onchange function
1ca977e
tests-checker[bot]
tests-checker bot suggested changes Nov 3, 2019
View reviewed changes
Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@netlify
Copy link

netlify bot commented Nov 3, 2019 •
edited

Deploy preview for ant-design ready!

Built with commit 1ca977e

https://deploy-preview-19535--ant-design.netlify.com

@hahmadia hahmadia closed this Nov 3, 2019
@codecov
Copy link

codecov bot commented Nov 3, 2019 •
edited

Codecov Report

Merging #19535 into feature will decrease coverage by 0.02%.
The diff coverage is 83.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #19535      +/-   ##
===========================================
- Coverage    97.81%   97.78%   -0.03%     
===========================================
  Files          284      282       -2     
  Lines         7695     7641      -54     
  Branches      2166     2155      -11     
===========================================
- Hits          7527     7472      -55     
- Misses         168      169       +1
Impacted Files Coverage Δ
components/date-picker/WeekPicker.tsx 100% <ø> (ø) ⬆️
components/date-picker/wrapPicker.tsx 98.9% <0%> (-1.1%) ⬇️
components/table/Table.tsx 99.48% <100%> (ø) ⬆️
components/upload/Upload.tsx 99.22% <100%> (ø) ⬆️
components/input/TextArea.tsx 96.49% <0%> (-3.51%) ⬇️
components/avatar/index.tsx 98.38% <0%> (-0.06%) ⬇️
components/transfer/index.tsx 98.7% <0%> (-0.05%) ⬇️
components/input/Input.tsx 100% <0%> (ø) ⬆️
components/input/ResizableTextArea.tsx
components/input/ClearableLabeledInput.tsx

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53efaa8...1ca977e. Read the comment docs.

@hahmadia hahmadia deleted the GH19386 branch November 3, 2019 20:19
@weekly-digest weekly-digest bot mentioned this pull request Nov 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tests-checker tests-checker[bot] tests-checker requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@hahmadia @hi-rustin @broder @NightFox7 @afc163 @wangweijun0418 @chnliquan @jacklee814 @MrHeer