Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: FormLabelAlign item types tuple #19543

Merged
merged 1 commit into from
Nov 4, 2019
Merged

Conversation

yoyo837
Copy link
Contributor

@yoyo837 yoyo837 commented Nov 4, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

close #19529

馃挕 Background and solution

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English
馃嚚馃嚦 Chinese 鏇存柊绫诲瀷瀹氫箟

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@yoyo837 yoyo837 changed the title FormLabelAlign item types tuple fix: FormLabelAlign item types tuple Nov 4, 2019
@auto-add-label auto-add-label bot added the bug label Nov 4, 2019
@netlify
Copy link

netlify bot commented Nov 4, 2019

Deploy preview for ant-design ready!

Built with commit 504e77c

https://deploy-preview-19543--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Nov 4, 2019

Codecov Report

Merging #19543 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #19543      +/-   ##
==========================================
+ Coverage   97.78%   97.78%   +<.01%     
==========================================
  Files         282      282              
  Lines        7640     7641       +1     
  Branches     2155     2155              
==========================================
+ Hits         7471     7472       +1     
  Misses        169      169
Impacted Files Coverage 螖
components/form/FormItem.tsx 98.87% <100%> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 0189244...504e77c. Read the comment docs.

@afc163 afc163 merged commit 3402f65 into master Nov 4, 2019
@afc163 afc163 deleted the fix-form-item-labelalign-types branch November 4, 2019 03:24
@zombieJ
Copy link
Member

zombieJ commented Nov 4, 2019

This update not fix user's typescript error. Conflict caused by propTypes define the labelAlign (as string) which not same with FormItemProps define.
Should remove propTypes instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proptype of labelAlign on Form.Item is not compatible with typescript type
3 participants