Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Delete duplicate variables #19547

Merged
merged 3 commits into from
Nov 4, 2019
Merged

chore: Delete duplicate variables #19547

merged 3 commits into from
Nov 4, 2019

Conversation

yoyo837
Copy link
Contributor

@yoyo837 yoyo837 commented Nov 4, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

ref: #17273#17613

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese 删除重复的@menu-icon-size@menu-icon-size-lg@menu-dark-selected-item-icon-color@menu-dark-selected-item-text-color; 调整顺序;删除@dark-menu-item-hover-bg,这里应该是笔误,另有@menu-dark-item-hover-bg

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@netlify
Copy link

netlify bot commented Nov 4, 2019

Deploy preview for ant-design ready!

Built with commit bac1323

https://deploy-preview-19547--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Nov 4, 2019

Codecov Report

Merging #19547 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #19547   +/-   ##
=======================================
  Coverage   97.78%   97.78%           
=======================================
  Files         282      282           
  Lines        7640     7640           
  Branches     2109     2143   +34     
=======================================
  Hits         7471     7471           
  Misses        169      169

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 696f560...bac1323. Read the comment docs.

@yoyo837 yoyo837 requested a review from afc163 November 4, 2019 03:29
@afc163 afc163 merged commit 187b103 into master Nov 4, 2019
@afc163 afc163 deleted the remove-vars-duplicated branch November 4, 2019 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants