Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Form): remove labelAlign PropTypes def #19550

Merged
merged 1 commit into from
Nov 4, 2019
Merged

Conversation

yoyo837
Copy link
Contributor

@yoyo837 yoyo837 commented Nov 4, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

馃挕 Background and solution

close #19529 again

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@netlify
Copy link

netlify bot commented Nov 4, 2019

Deploy preview for ant-design ready!

Built with commit 5889f78

https://deploy-preview-19550--ant-design.netlify.com

@yoyo837 yoyo837 changed the title remove labelAlign PropTypes def fix: remove labelAlign PropTypes def Nov 4, 2019
@auto-add-label auto-add-label bot added the bug label Nov 4, 2019
@yoyo837 yoyo837 changed the title fix: remove labelAlign PropTypes def fix(Form): remove labelAlign PropTypes def Nov 4, 2019
@codecov
Copy link

codecov bot commented Nov 4, 2019

Codecov Report

Merging #19550 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #19550   +/-   ##
=======================================
  Coverage    97.8%    97.8%           
=======================================
  Files         284      284           
  Lines        7698     7698           
  Branches     2117     2117           
=======================================
  Hits         7529     7529           
  Misses        169      169
Impacted Files Coverage 螖
components/form/FormItem.tsx 98.87% <酶> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update e88f021...5889f78. Read the comment docs.

@afc163 afc163 mentioned this pull request Nov 4, 2019
10 tasks
@afc163 afc163 merged commit 7158142 into master Nov 4, 2019
@afc163 afc163 deleted the labelAlign-ts-conflict branch November 4, 2019 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proptype of labelAlign on Form.Item is not compatible with typescript type
2 participants