fix: typography ellipsis wrong when browser zoomed #19661
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for ant-design ready! Built with commit 74082de |
Codecov Report
@@ Coverage Diff @@
## master #19661 +/- ##
=======================================
Coverage 97.81% 97.81%
=======================================
Files 286 286
Lines 7737 7737
Branches 2176 2176
=======================================
Hits 7568 7568
Misses 169 169Continue to review full report at Codecov.
|
shaodahong
reviewed
Nov 11, 2019
components/typography/util.tsx
Outdated
| const windowScale = window.devicePixelRatio; | ||
| ellipsisContainer.innerHTML = originEle.innerText && originEle.innerText[0] || ''; | ||
|
|
||
| const realLineHeight = windowScale < 1 ? |
afc163
reviewed
Dec 17, 2019
components/typography/util.tsx
Outdated
| @@ -170,6 +178,7 @@ export default ( | |||
| } | |||
|
|
|||
| if (inRange()) { | |||
|
|
|||
afc163
changed the title
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 74082de:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃 This is a ...
馃敆 Related issue link
#19219
馃挕 Background and solution
Typography.Paragraph ellipsis error when scale browser
馃摑 Changelog
鈽戯笍 Self Check before Merge