fix: style of sidebar Tabs' width #19691
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for ant-design ready! Built with commit 455b105 |
shaodahong
reviewed
Nov 12, 2019
| @@ -364,6 +364,10 @@ | |||
| .@{tab-prefix-cls}-tab { | |||
| text-align: right; | |||
| } | |||
| .@{tab-prefix-cls}-tab-active { | |||
| font-weight: normal; | |||
| text-shadow: 0px 0px 1px @tabs-card-active-color; | |||
There was a problem hiding this comment.
Thanks, I don't think text-shadow is a good idea, and it's doesn't support IE 9 browser, I will close this PR, via react-component/tabs#221 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃 This is a ...
馃敆 Related issue link
#18652
馃挕 Background and solution
馃摑 Changelog
鈽戯笍 Self Check before Merge