Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Removed version column in 4.0 #19825

Merged
merged 3 commits into from Nov 20, 2019
Merged

docs: Removed version column in 4.0 #19825

merged 3 commits into from Nov 20, 2019

Conversation

472756921
Copy link
Contributor

@472756921 472756921 commented Nov 20, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue

ref: #19815

💡 Background and solution

ref: #19815

📝 Changelog

Language Changelog
🇺🇸 English Removed version column in 4.0
🇨🇳 Chinese 删除相关版本号

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/breadcrumb/index.zh-CN.md
View rendered components/dropdown/index.en-US.md
View rendered components/dropdown/index.zh-CN.md

@netlify
Copy link

netlify bot commented Nov 20, 2019

Deploy preview for ant-design ready!

Built with commit 4ab6c7a

https://deploy-preview-19825--ant-design.netlify.com

@472756921 472756921 changed the title Benson chen docs: Removed version column in 4.0 Nov 20, 2019
@yoyo837 yoyo837 requested a review from zombieJ November 20, 2019 07:00
@codecov
Copy link

codecov bot commented Nov 20, 2019

Codecov Report

Merging #19825 into 4.0-prepare will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           4.0-prepare   #19825   +/-   ##
============================================
  Coverage        97.46%   97.46%           
============================================
  Files              288      288           
  Lines             7219     7219           
  Branches          1996     1996           
============================================
  Hits              7036     7036           
  Misses             183      183

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a13af0...4ab6c7a. Read the comment docs.

@zombieJ
Copy link
Member

zombieJ commented Nov 20, 2019

components/breadcrumb/index.en-US.md seems not sync with components/breadcrumb/index.zh-CN.md. Should update English version.

@zombieJ zombieJ merged commit 4be963d into ant-design:4.0-prepare Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants