Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(update): removed 3.x version description in 4.0-prepare #19827

Merged
merged 3 commits into from Nov 20, 2019
Merged

docs(update): removed 3.x version description in 4.0-prepare #19827

merged 3 commits into from Nov 20, 2019

Conversation

@netlify
Copy link

netlify bot commented Nov 20, 2019

Deploy preview for ant-design ready!

Built with commit 91445b1

https://deploy-preview-19827--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Nov 20, 2019

Codecov Report

Merging #19827 into 4.0-prepare will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           4.0-prepare   #19827   +/-   ##
============================================
  Coverage        97.46%   97.46%           
============================================
  Files              288      288           
  Lines             7219     7219           
  Branches          1996     1957   -39     
============================================
  Hits              7036     7036           
  Misses             183      183

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 336fb41...91445b1. Read the comment docs.

@yoyo837 yoyo837 requested a review from zombieJ November 20, 2019 07:51
| goTo(slideNumber, dontAnimate) | 切换到指定面板, dontAnimate = true 时,不使用动画 | 3.9.3 |
| next() | 切换到下一面板 | |
| prev() | 切换到上一面板 | |
| 名称 | 描述 | 版本 |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

原本没有的不用特地加

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个问题是 carousel 的

  • index.en-US.md 有一个 3.9.3
  • index.zh-CN.md 没有版本这一栏

以哪个为准,需要保持一致吗?
还是只回退这个改动

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

都删除好了

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

remove carousel/index.zh-CN.md empty version column
remove carousel/index.en-US.md empty version column
@zombieJ zombieJ merged commit c93bd32 into ant-design:4.0-prepare Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants