Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 🔧 remove antd/es/form/__tests__ from npm package #20069

Merged
merged 1 commit into from
Dec 4, 2019

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Dec 4, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

Remove https://unpkg.com/browse/antd@3.26.0/es/form/__tests__/

📝 Changelog

Language Changelog
🇺🇸 English -
🇨🇳 Chinese -

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@netlify
Copy link

netlify bot commented Dec 4, 2019

Deploy preview for ant-design ready!

Built with commit c945ffd

https://deploy-preview-20069--ant-design.netlify.com

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 4, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c945ffd:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Dec 4, 2019

Codecov Report

Merging #20069 into master will decrease coverage by 0.39%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #20069     +/-   ##
=========================================
- Coverage   97.81%   97.42%   -0.4%     
=========================================
  Files         286      287      +1     
  Lines        7737     7768     +31     
  Branches     2173     2176      +3     
=========================================
  Hits         7568     7568             
- Misses        169      200     +31
Impacted Files Coverage Δ
components/form/__tests__/type.test.tsx 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fac56ee...c945ffd. Read the comment docs.

describe('Form TypeScript test', async () => {
// empty
});

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个文件后面需要用 https://github.com/SamVerschueren/tsd 来做测试。

@zombieJ zombieJ merged commit bca69b6 into master Dec 4, 2019
@zombieJ zombieJ deleted the fix-form-__tests__ branch December 4, 2019 04:07
@afc163
Copy link
Member Author

afc163 commented Dec 4, 2019

image

虚假的覆盖率 😢..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants