Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Select empty style & default width #20232

Merged
merged 7 commits into from
Dec 20, 2019
Merged

fix: Select empty style & default width #20232

merged 7 commits into from
Dec 20, 2019

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Dec 13, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #20146
fix #19889

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Select provides default width and not show dropdown when notFoundContent is null.
🇨🇳 Chinese

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@netlify
Copy link

netlify bot commented Dec 13, 2019

Deploy preview for ant-design ready!

Built with commit 1526f6d

https://deploy-preview-20232--ant-design.netlify.com

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 13, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1526f6d:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Dec 13, 2019

Codecov Report

Merging #20232 into 4.0-prepare will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff               @@
##           4.0-prepare   #20232      +/-   ##
===============================================
+ Coverage        97.55%   97.56%   +<.01%     
===============================================
  Files              294      295       +1     
  Lines             6839     6849      +10     
  Branches          1839     1879      +40     
===============================================
+ Hits              6672     6682      +10     
  Misses             167      167
Impacted Files Coverage Δ
components/skeleton/Skeleton.tsx 100% <ø> (ø) ⬆️
components/skeleton/index.tsx 100% <100%> (ø) ⬆️
components/skeleton/Input.tsx 100% <100%> (ø)
components/alert/ErrorBoundary.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1dfe8b...1526f6d. Read the comment docs.

@shaodahong
Copy link
Member

Missing cursor

Kapture 2019-12-13 at 14 35 52

@zombieJ
Copy link
Member Author

zombieJ commented Dec 13, 2019

@shaodahong , pls help to check again.

@shaodahong

This comment has been minimized.

@shaodahong
Copy link
Member

Arrow top height not correct

image

@shaodahong
Copy link
Member

Empty Option when hidden
(隐藏的时候出现了空 Option)

Kapture 2019-12-13 at 17 01 21

@shaodahong
Copy link
Member

Group indent is missing

image

@shaodahong
Copy link
Member

Missing input hover bordered

@zombieJ
Copy link
Member Author

zombieJ commented Dec 20, 2019

Empty Option when hidden
(隐藏的时候出现了空 Option)

Kapture 2019-12-13 at 17 01 21

这个开个新的 issue,样式的先合了。

@shaodahong
Copy link
Member

嗯,我提的有些和 #20229 重复了,可以一起过一下

@zombieJ
Copy link
Member Author

zombieJ commented Dec 20, 2019

嗯,分几个 PR 逐步更新。免得太大合不掉了。

Copy link
Member

@shaodahong shaodahong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zombieJ zombieJ merged commit 2b30934 into 4.0-prepare Dec 20, 2019
@zombieJ zombieJ deleted the select-style branch December 20, 2019 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants