Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix #21103 update clearfix mixin #21109

Merged
merged 1 commit into from Jan 26, 2020

Conversation

morenyang
Copy link
Contributor

@morenyang morenyang commented Jan 26, 2020

Refs: https://github.com/twbs/bootstrap/blob/ff29c1224c20b8fcf2d1e7c28426470f1dc3e40d/scss/mixins/_clearfix.scss

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

close #21103

馃挕 Background and solution

Follow bootstrap's clearfix solution.

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English Update clearfix mixin.
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Jan 26, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Jan 26, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4cd1bec:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Jan 26, 2020

Codecov Report

Merging #21109 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #21109   +/-   ##
=======================================
  Coverage   97.48%   97.48%           
=======================================
  Files         296      296           
  Lines        6911     6911           
  Branches     1918     1907   -11     
=======================================
  Hits         6737     6737           
  Misses        174      174

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 3ee4d82...4cd1bec. Read the comment docs.

@yoyo837 yoyo837 changed the title fix #21103 update clearfix mixin fix: fix #21103 update clearfix mixin Jan 26, 2020
@auto-add-label auto-add-label bot added the bug label Jan 26, 2020
@afc163 afc163 merged commit bf56026 into ant-design:master Jan 26, 2020
18 checks passed
@zombieJ zombieJ mentioned this pull request Jan 27, 2020
10 tasks
@morenyang morenyang deleted the update-clearfix-mixin branch Jan 28, 2020
@afc163 afc163 mentioned this pull request Feb 10, 2020
14 tasks
@afc163
Copy link
Member

@afc163 afc163 commented Mar 4, 2020

breaks #21864

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants