Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Menu collapsed jumping #21314

Merged
merged 1 commit into from Feb 10, 2020
Merged

fix: Menu collapsed jumping #21314

merged 1 commit into from Feb 10, 2020

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Feb 10, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #21301

💡 Background and solution

Revert #21109

📝 Changelog

Language Changelog
🇺🇸 English Fix Menu collapsed with jumpy padding.
🇨🇳 Chinese 修复 Menu 收缩二级菜单时的内边距跳跃问题。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@afc163 afc163 changed the title 🐛 Fix Menu collapsed jumping fix Menu collapsed jumping Feb 10, 2020
@afc163 afc163 changed the title fix Menu collapsed jumping fix: Menu collapsed jumping Feb 10, 2020
@afc163 afc163 changed the title fix Menu collapsed jumping fix: Menu collapsed jumping Feb 10, 2020
@afc163 afc163 changed the title fix Menu collapsed jumping fix: Menu collapsed jumping Feb 10, 2020
@ant-design-bot
Copy link
Contributor

ant-design-bot commented Feb 10, 2020

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 34e5e42:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Feb 10, 2020

Codecov Report

Merging #21314 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #21314   +/-   ##
=======================================
  Coverage   97.55%   97.55%           
=======================================
  Files         300      300           
  Lines        6999     6999           
  Branches     1929     1918   -11     
=======================================
  Hits         6828     6828           
  Misses        171      171

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5000773...34e5e42. Read the comment docs.

@afc163 afc163 merged commit cf4808b into master Feb 10, 2020
@afc163 afc163 deleted the fix-menu-style branch February 10, 2020 05:50
@afc163
Copy link
Member Author

afc163 commented Feb 10, 2020

close #21209 too.

@afc163 afc163 mentioned this pull request Feb 10, 2020
1 task
@yoyo837
Copy link
Contributor

yoyo837 commented Feb 12, 2020

@afc163 请问下,官网渲染 demo 组件用的是右上角版本还是master代码?

@afc163
Copy link
Member Author

afc163 commented Feb 12, 2020

右上角显示什么就是什么版本。

@afc163
Copy link
Member Author

afc163 commented Feb 12, 2020

next.ant.design 现在是手动部署,版本不一定。可以找 @zombieJ 触发。

@yoyo837
Copy link
Contributor

yoyo837 commented Feb 12, 2020

不干预就是右上角版本?我看现在next里当前修复已经生效了。但是并没有发rc5.

@afc163
Copy link
Member Author

afc163 commented Feb 12, 2020

那就是 master 的某一个 commit。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Menu导航菜单在切换Item时出现延迟和卡顿以及展开和收缩时出现抖动。
3 participants