Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Form.Item with name 0 should be validate #21179

Merged
merged 2 commits into from Feb 2, 2020
Merged

fix: Form.Item with name 0 should be validate #21179

merged 2 commits into from Feb 2, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Feb 2, 2020

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

close #21132

馃挕 Background and solution

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English Fix Form.Item with number name 0 will fail to bind field.
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Feb 2, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 2, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 139e1d9:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Feb 2, 2020

Codecov Report

Merging #21179 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #21179   +/-   ##
=======================================
  Coverage   97.45%   97.45%           
=======================================
  Files         296      296           
  Lines        6913     6913           
  Branches     1871     1919   +48     
=======================================
  Hits         6737     6737           
  Misses        176      176
Impacted Files Coverage 螖
components/form/FormItem.tsx 98.96% <100%> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 92998e6...139e1d9. Read the comment docs.

@zombieJ zombieJ merged commit 207fc03 into master Feb 2, 2020
@zombieJ zombieJ deleted the form-list branch February 2, 2020 14:28
@wanjas wanjas mentioned this pull request Feb 3, 2020
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants