Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Typography editable should focus at the end #21268

Merged
merged 1 commit into from Feb 7, 2020
Merged

fix: Typography editable should focus at the end #21268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 5 additions & 2 deletions components/typography/Editable.tsx
View file
Open in desktop
Expand Up @@ -46,8 +46,11 @@ class Editable extends React.Component<EditableProps, EditableState> {
};

componentDidMount() {
if (this.textarea) {
this.textarea.focus();
if (this.textarea && this.textarea.resizableTextArea) {
const { textArea } = this.textarea.resizableTextArea;
textArea.focus();
const { length } = textArea.value;
textArea.setSelectionRange(length, length);
}
}

Expand Down
11 changes: 11 additions & 0 deletions components/typography/__tests__/index.test.js
View file
Open in desktop
Expand Up @@ -287,6 +287,17 @@ describe('Typography', () => {
wrapper.find('TextArea').simulate('blur');
});
});

it('should focus at the end of textarea', () => {
const wrapper = mount(<Paragraph editable>content</Paragraph>);
wrapper
.find('.ant-typography-edit')
.first()
.simulate('click');
const textareaNode = wrapper.find('textarea').getDOMNode();
expect(textareaNode.selectionStart).toBe(7);
expect(textareaNode.selectionEnd).toBe(7);
});
});

it('warning if use setContentRef', () => {
Expand Down