Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Badge color not working when contains children #21333

Merged
merged 1 commit into from Feb 11, 2020
Merged

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Feb 11, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #21331

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Badge color not working when contains children.
🇨🇳 Chinese 修复 Badge 包裹模式下 color 属性失效的问题。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@afc163 afc163 changed the title fix Badge color not working when contains children fix: Badge color not working when contains children Feb 11, 2020
@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Feb 11, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Feb 11, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ed53be1:

Sandbox Source
antd reproduction template Configuration
async-rain-1fkqd Issue #21331

@codecov
Copy link

@codecov codecov bot commented Feb 11, 2020

Codecov Report

Merging #21333 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #21333      +/-   ##
==========================================
+ Coverage   97.55%   97.55%   +<.01%     
==========================================
  Files         300      300              
  Lines        6999     7003       +4     
  Branches     1929     1884      -45     
==========================================
+ Hits         6828     6832       +4     
  Misses        171      171
Impacted Files Coverage Δ
components/badge/index.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e419b2...ed53be1. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants