Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Form item has default height align with form size #21476

Merged
merged 3 commits into from
Feb 19, 2020
Merged

fix: Form item has default height align with form size #21476

merged 3 commits into from
Feb 19, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Feb 19, 2020 •
edited by markdownify bot
Loading

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #21468

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Form.Item with help align style.
🇨🇳 Chinese 修复 Form.Item 设置 help 时的样式问题。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/form/demo/validate-other.md

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Feb 19, 2020 •
edited
Loading

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 21b3389:

Sandbox Source
antd reproduction template Configuration

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 19, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 83636ee:

Sandbox Source
antd reproduction template Configuration

@zombieJ zombieJ requested a review from afc163 February 19, 2020 13:53
@zombieJ
Copy link
Member Author

zombieJ commented Feb 19, 2020

Add one more div to align the center.

@codecov
Copy link

codecov bot commented Feb 19, 2020 •
edited
Loading

Codecov Report

Merging #21476 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #21476      +/-   ##
==========================================
+ Coverage   97.83%   97.83%   +<.01%     
==========================================
  Files         302      302              
  Lines        7016     7018       +2     
  Branches     1934     1888      -46     
==========================================
+ Hits         6864     6866       +2     
  Misses        152      152
Impacted Files Coverage Δ
components/form/FormItemInput.tsx 93.33% <ø> (ø) ⬆️
components/form/Form.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bb0aaf...83636ee. Read the comment docs.

@zombieJ zombieJ merged commit 9f26e7a into master Feb 19, 2020
@zombieJ zombieJ deleted the form-help branch February 19, 2020 14:04
@pr-triage pr-triage bot added the PR: merged label Feb 19, 2020
zombieJ added a commit that referenced this pull request Feb 19, 2020
@zombieJ
chore: Patch fix of #21476
9a90c5b
@zombieJ zombieJ mentioned this pull request Feb 20, 2020
Closed
1 task
@ycjcl868 ycjcl868 mentioned this pull request Feb 24, 2020
Merged
afc163
afc163 reviewed Feb 25, 2020
View reviewed changes
components/form/style/index.less
@@ -123,7 +143,13 @@

&-control-input {
position: relative;
.clearfix;
display: flex;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这句话把 #21586 搞坏了。

yoyo837
yoyo837 reviewed Mar 4, 2020
View reviewed changes
components/form/style/index.less
@@ -67,7 +87,7 @@
display: inline-flex;
align-items: center;
height: 100%;
max-height: @input-height-base;
height: @input-height-base;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里重复了一个height

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

提个 issue。

@yoyo837 yoyo837 mentioned this pull request Mar 4, 2020
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afc163 afc163 afc163 left review comments

@yoyo837 yoyo837 yoyo837 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

form表单label错位
4 participants
@zombieJ @ant-design-bot @afc163 @yoyo837