Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removes erroniously present comment #21792

Merged
merged 1 commit into from Mar 3, 2020

Conversation

dimitropoulos
Copy link
Contributor

This comment was an accidental copy/pasta from https://reactjs.org/docs/error-boundaries.html. Also, it is inaccurate since the user (i.e. AntD user) cannot actually render any fallback component.

馃 This is a ...

  • Bug fix

馃敆 Related issue link

https://reactjs.org/docs/error-boundaries.html

馃挕 Background and solution

removal of the comment

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

This comment was an accidental copy/pasta from https://reactjs.org/docs/error-boundaries.html.  Also, it is inaccurate since the user (i.e. AntD user) cannot actually render any fallback component.
@ant-design-bot
Copy link
Contributor

ant-design-bot commented Mar 2, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 2, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c754c9c:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Mar 2, 2020

Codecov Report

Merging #21792 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #21792   +/-   ##
=======================================
  Coverage   97.88%   97.88%           
=======================================
  Files         305      305           
  Lines        6999     6999           
  Branches     1931     1919   -12     
=======================================
  Hits         6851     6851           
  Misses        148      148
Impacted Files Coverage 螖
components/alert/ErrorBoundary.tsx 100% <酶> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update ccca0f3...c754c9c. Read the comment docs.

@yoyo837 yoyo837 changed the title removes erroniously present comment chore: removes erroniously present comment Mar 3, 2020
@yoyo837
Copy link
Contributor

yoyo837 commented Mar 3, 2020

ref: #19923

@yoyo837 yoyo837 requested a review from afc163 March 3, 2020 02:03
@afc163 afc163 merged commit fd9bc6c into ant-design:master Mar 3, 2020
@pr-triage pr-triage bot added the PR: merged label Mar 3, 2020
@dimitropoulos dimitropoulos deleted the patch-3 branch March 3, 2020 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants