Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pagination could change its size by the width of the window #21959

Merged
merged 5 commits into from Mar 10, 2020

Conversation

hullis
Copy link
Contributor

@hullis hullis commented Mar 7, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#21885

💡 Background and solution

如果用户没有指定 pagination 的 size,且传递了 autoResize 时,当屏幕缩小到 xs,会自动呈现为 small 样式。
为了让用户能够在小屏幕上使用默认样式,size 参数新增 default 类型。

📝 Changelog

Language Changelog
🇺🇸 English Pagination 新增 autoResize 属性
🇨🇳 Chinese Pagination supports autoResize prop

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
  • Test is provided

View rendered components/pagination/index.en-US.md
View rendered components/pagination/index.zh-CN.md

@hullis hullis changed the base branch from master to feature Mar 7, 2020
@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Mar 7, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Mar 7, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 545538a:

Sandbox Source
antd reproduction template Configuration

@afc163
Copy link
Member

@afc163 afc163 commented Mar 7, 2020

别自动,来一个开关属性,默认关闭。

@hullis hullis force-pushed the pagination-auto-small branch from e94c6da to c1f61b2 Compare Mar 8, 2020
@codecov
Copy link

@codecov codecov bot commented Mar 8, 2020

Codecov Report

Merging #21959 into feature will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           feature   #21959   +/-   ##
========================================
  Coverage    97.97%   97.98%           
========================================
  Files          307      307           
  Lines         7076     7087   +11     
  Branches      1953     1957    +4     
========================================
+ Hits          6933     6944   +11     
  Misses         143      143           
Impacted Files Coverage Δ
components/pagination/Pagination.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cff8c08...545538a. Read the comment docs.

components/pagination/Pagination.tsx Outdated Show resolved Hide resolved
components/pagination/Pagination.tsx Outdated Show resolved Hide resolved
afc163
afc163 approved these changes Mar 10, 2020
@afc163
Copy link
Member

@afc163 afc163 commented Mar 10, 2020

ci broken

@hullis
Copy link
Contributor Author

@hullis hullis commented Mar 10, 2020

Fixed.

@afc163 afc163 merged commit 584d0ae into ant-design:feature Mar 10, 2020
19 checks passed
@hullis hullis deleted the pagination-auto-small branch Mar 10, 2020
@zombieJ zombieJ mentioned this pull request Mar 29, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants