Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: changed display of anticon #22090

Merged
merged 1 commit into from Mar 11, 2020
Merged

style: changed display of anticon #22090

merged 1 commit into from Mar 11, 2020

Conversation

x1mrdonut1x
Copy link
Contributor

@x1mrdonut1x x1mrdonut1x commented Mar 10, 2020

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃挕 Background and solution

I found the icon transition when collapsing the Menu component to not look very nice.

Old solution:

Alt Text
broken icon transition

New solution:
Alt Text
Seamless icon transition

鈽戯笍 Self Check before Merge

鈿狅笍 Please check all items below before review. 鈿狅笍

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@x1mrdonut1x x1mrdonut1x changed the title changed display of anticon fix: changed display of anticon Mar 10, 2020
@x1mrdonut1x x1mrdonut1x changed the title fix: changed display of anticon style: changed display of anticon Mar 10, 2020
@ant-design-bot
Copy link
Contributor

ant-design-bot commented Mar 10, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 10, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 597f460:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Mar 10, 2020

Codecov Report

Merging #22090 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #22090   +/-   ##
=======================================
  Coverage   97.96%   97.96%           
=======================================
  Files         306      306           
  Lines        7041     7041           
  Branches     1928     1939   +11     
=======================================
  Hits         6898     6898           
  Misses        143      143

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 33e726f...597f460. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants