Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: fix dropdown menu icon #22098

Merged
merged 3 commits into from
Mar 11, 2020
Merged

style: fix dropdown menu icon #22098

merged 3 commits into from
Mar 11, 2020

Conversation

xrkffgg
Copy link
Member

@xrkffgg xrkffgg commented Mar 11, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

补充 #21768

📝 Changelog

Language Changelog
🇺🇸 English Fixed Dropdown content and icons overlapping
🇨🇳 Chinese 修正 Dropdown 内容和图标重叠问题

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@yoyo837
Copy link
Contributor

yoyo837 commented Mar 11, 2020

要不,背景写一下因为啥补充!?

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Mar 11, 2020

@xrkffgg
Copy link
Member Author

xrkffgg commented Mar 11, 2020

我写在 changelog 里了,话说我 @ 他,你怎么在一个 closed PR 发现啦

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 11, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c29bc9a:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Mar 11, 2020

Codecov Report

Merging #22098 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #22098   +/-   ##
=======================================
  Coverage   97.96%   97.96%           
=======================================
  Files         306      306           
  Lines        7041     7041           
  Branches     1928     1928           
=======================================
  Hits         6898     6898           
  Misses        143      143

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33e726f...c29bc9a. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 11, 2020

Codecov Report

Merging #22098 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #22098   +/-   ##
=======================================
  Coverage   97.96%   97.96%           
=======================================
  Files         306      306           
  Lines        7041     7041           
  Branches     1928     1939   +11     
=======================================
  Hits         6898     6898           
  Misses        143      143           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33e726f...bebab64. Read the comment docs.

@yoyo837
Copy link
Contributor

yoyo837 commented Mar 11, 2020

Watch repo anything activity.

@yoyo837 yoyo837 requested a review from afc163 March 11, 2020 02:41
@xrkffgg
Copy link
Member Author

xrkffgg commented Mar 11, 2020

just 666

@afc163
Copy link
Member

afc163 commented Mar 11, 2020

把这个优先级提起来:https://github.com/ant-design/ant-design/pull/21768/files#diff-1afa51859d202927a0eb117e03ac1413R192

不要改外面的 padding。

@xrkffgg
Copy link
Member Author

xrkffgg commented Mar 11, 2020

等下,RTL 还有点问题

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants