Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: useBreakpoint hook #22226

Merged
merged 5 commits into from Mar 15, 2020
Merged

feat: useBreakpoint hook #22226

merged 5 commits into from Mar 15, 2020

Conversation

shaodahong
Copy link
Member

@shaodahong shaodahong commented Mar 15, 2020

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

Closed #13785

馃挕 Background and solution

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English useBreakpoint hook
馃嚚馃嚦 Chinese useBreakpoint hook

鈽戯笍 Self Check before Merge

鈿狅笍 Please check all items below before review. 鈿狅笍

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/grid/demo/useBreakpoint.md

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Mar 15, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 15, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 70837b6:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Mar 15, 2020

Codecov Report

Merging #22226 into feature will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #22226      +/-   ##
===========================================
+ Coverage    97.98%   97.98%   +<.01%     
===========================================
  Files          358      359       +1     
  Lines         7147     7154       +7     
  Branches      1915     1915              
===========================================
+ Hits          7003     7010       +7     
  Misses         144      144
Impacted Files Coverage 螖
components/index.tsx 100% <酶> (酶) 猬嗭笍
components/grid/hooks/useBreakpoint.tsx 100% <100%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 869f93d...70837b6. Read the comment docs.

@afc163
Copy link
Member

afc163 commented Mar 15, 2020

LGTM

afc163
afc163 approved these changes Mar 15, 2020
@afc163
Copy link
Member

afc163 commented Mar 15, 2020

娴嬭瘯瑕嗙洊鐜囪琛ヤ竴涓

@shaodahong
Copy link
Member Author

shaodahong commented Mar 15, 2020

Done.

@afc163 afc163 merged commit 61d0d6b into ant-design:feature Mar 15, 2020
19 checks passed
@shaodahong shaodahong deleted the useBreakpoint branch Mar 15, 2020
@zombieJ zombieJ mentioned this pull request Mar 29, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants