Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🆕 Add keyboard prop to Tabs #22287

Merged
merged 4 commits into from Mar 17, 2020
Merged

feat: 🆕 Add keyboard prop to Tabs #22287

merged 4 commits into from Mar 17, 2020

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Mar 17, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English - ⌨️ Improve Tabs Accessibility.
- Add Tabs keyboard prop.
- Tabs extraContent don't trigger keyboard navigation now.
🇨🇳 Chinese - ⌨️ 增强 Tabs 可访问性。
- 新增 Tabs keyboard 属性用于开关键盘切换功能。
- Tabs extraContent 里的元素不再触发键盘切换功能。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/tabs/index.en-US.md
View rendered components/tabs/index.zh-CN.md

@pr-triage pr-triage bot added the PR: draft label Mar 17, 2020
@ant-design-bot
Copy link
Contributor

ant-design-bot commented Mar 17, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 17, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 02c314c:

Sandbox Source
antd reproduction template Configuration

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 17, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d425374:

Sandbox Source
antd reproduction template Configuration

@afc163 afc163 marked this pull request as ready for review Mar 17, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 17, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9bed2c8:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Mar 17, 2020

Codecov Report

Merging #22287 into feature will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           feature   #22287   +/-   ##
========================================
  Coverage    97.98%   97.98%           
========================================
  Files          359      359           
  Lines         7155     7155           
  Branches      1960     1960           
========================================
  Hits          7011     7011           
  Misses         144      144
Impacted Files Coverage Δ
components/tabs/index.tsx 96.87% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b756646...9bed2c8. Read the comment docs.

@afc163 afc163 merged commit 96bc5df into feature Mar 17, 2020
29 checks passed
@afc163 afc163 deleted the upgrade-tabs branch Mar 17, 2020
@zombieJ zombieJ mentioned this pull request Mar 29, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants