Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(backtop): rewrite with hook #23575

Merged
merged 5 commits into from May 16, 2020
Merged

refactor(backtop): rewrite with hook #23575

merged 5 commits into from May 16, 2020

Conversation

xrkffgg
Copy link
Member

@xrkffgg xrkffgg commented Apr 24, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English refactor with hook
🇨🇳 Chinese 用 react hook 重构

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@xrkffgg xrkffgg added this to WIP in Refactor with React Hooks via automation Apr 24, 2020
@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Apr 24, 2020

@lgtm-com
Copy link

@lgtm-com lgtm-com bot commented Apr 24, 2020

This pull request introduces 1 alert when merging a353b92 into d50cc55 - view on LGTM.com

new alerts:

  • 1 for Unneeded defensive code

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Apr 24, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 42fa0a6:

Sandbox Source
antd reproduction template Configuration

@xrkffgg
Copy link
Member Author

@xrkffgg xrkffgg commented Apr 28, 2020

@hengkx 这个组件你帮忙看看,如果需要什么改动,你直接在这个分支 改吧。

最近网站方面的有点多,这个我暂时顾不上啦。

components/back-top/index.tsx Outdated Show resolved Hide resolved
@lgtm-com
Copy link

@lgtm-com lgtm-com bot commented Apr 28, 2020

This pull request introduces 1 alert when merging a0836bc into 53a76f0 - view on LGTM.com

new alerts:

  • 1 for Unneeded defensive code

@xrkffgg xrkffgg changed the title refactor(backtop): rewrite with hook [WIP] refactor(backtop): rewrite with hook Apr 28, 2020
@hengkx
Copy link
Member

@hengkx hengkx commented Apr 28, 2020

好 我看看

@codecov
Copy link

@codecov codecov bot commented Apr 28, 2020

Codecov Report

Merging #23575 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23575      +/-   ##
==========================================
- Coverage   98.82%   98.81%   -0.01%     
==========================================
  Files         364      364              
  Lines        7291     7285       -6     
  Branches     2019     1967      -52     
==========================================
- Hits         7205     7199       -6     
  Misses         86       86              
Impacted Files Coverage Δ
components/back-top/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a83143b...091c0fd. Read the comment docs.

@afc163
Copy link
Member

@afc163 afc163 commented May 7, 2020

/rebase

@hengkx
Copy link
Member

@hengkx hengkx commented May 15, 2020

/rebase

@lgtm-com
Copy link

@lgtm-com lgtm-com bot commented May 15, 2020

This pull request introduces 1 alert when merging d82f727 into 610807e - view on LGTM.com

new alerts:

  • 1 for Unneeded defensive code

@hengkx
Copy link
Member

@hengkx hengkx commented May 15, 2020

这个pr 怎么了 为什么 我的eslint都失效了

@lgtm-com
Copy link

@lgtm-com lgtm-com bot commented May 15, 2020

This pull request introduces 1 alert when merging f2a83fd into 610807e - view on LGTM.com

new alerts:

  • 1 for Unneeded defensive code

@hengkx
Copy link
Member

@hengkx hengkx commented May 15, 2020

这个pr 怎么了 为什么 我的eslint都失效了

我的错 弄错 文件夹了

@hengkx
Copy link
Member

@hengkx hengkx commented May 15, 2020

/rebase

@hengkx
Copy link
Member

@hengkx hengkx commented May 15, 2020

为什么rebase都是失败Uploading 82027980...

@yoyo837
Copy link
Contributor

@yoyo837 yoyo837 commented May 15, 2020

因为有冲突

@lgtm-com
Copy link

@lgtm-com lgtm-com bot commented May 15, 2020

This pull request introduces 1 alert when merging c895e95 into a83143b - view on LGTM.com

new alerts:

  • 1 for Unneeded defensive code

@hengkx hengkx changed the title [WIP] refactor(backtop): rewrite with hook refactor(backtop): rewrite with hook May 15, 2020
@hengkx hengkx requested review from afc163, orzyyyy and saeedrahimi May 16, 2020
@afc163 afc163 merged commit 9924bbf into master May 16, 2020
35 checks passed
Refactor with React Hooks automation moved this from WIP to Done May 16, 2020
@afc163 afc163 deleted the ref-backtop branch May 16, 2020
@Innei Innei mentioned this pull request May 20, 2020
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants