fix: Modal async #23826
Merged
fix: Modal async #23826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![tests-checker[bot]](https://avatars.githubusercontent.com/in/17064?s=60&v=4){kind=small}
afc163
reviewed
May 2, 2020
| * https://github.com/ant-design/ant-design/issues/23623 | ||
| * Sync render blocks React event. Let's make this async. | ||
| */ | ||
| setTimeout(() => { |
There was a problem hiding this comment.
不用，Modal.xxx 没有生命周期。clear 用的是 Modal.destroyAll
There was a problem hiding this comment.
这么说 destroyAll 和 destroy 的时候是需要 clear 的，万一两个方法连续调用。
Modal.confirm();
Modal.destroyAll();
|
|
|
/rebase |
github-actions
bot
force-pushed
the
async-modal
branch
from
8af51d7
to
1ee9912
Compare
静态方法是在 React 生命周期外的，没有调用 portal 的时机。 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
resolve #23623
💡 Background and solution
📝 Changelog
☑️ Self Check before Merge