Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #24544 support -readonly suffix on ant-input-affix-wrapper #24551

Merged

Conversation

morenyang
Copy link
Contributor

@morenyang morenyang commented May 28, 2020

[中文版模板 / Chinese template]

close #24544

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Perfermance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#24544

💡 Background and solution

  • add readOnly case in classnames

📝 Changelog

Language Changelog
🇺🇸 English no need
🇨🇳 Chinese no need

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@afc163
Copy link
Member

afc163 commented May 28, 2020

master branch

@ant-design-bot
Copy link
Contributor

ant-design-bot commented May 28, 2020

@morenyang morenyang force-pushed the input-affix-wrapper-readonly-class-name branch from 15ed284 to 3c593b8 Compare May 28, 2020 15:16
@morenyang morenyang changed the base branch from feature to master May 28, 2020 15:16
@codecov
Copy link

codecov bot commented May 28, 2020

Codecov Report

Merging #24551 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24551   +/-   ##
=======================================
  Coverage   99.14%   99.14%           
=======================================
  Files         363      363           
  Lines        7363     7363           
  Branches     2012     2012           
=======================================
  Hits         7300     7300           
  Misses         63       63           
Impacted Files Coverage Δ
components/input/ClearableLabeledInput.tsx 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ada8161...baf754c. Read the comment docs.

@morenyang morenyang force-pushed the input-affix-wrapper-readonly-class-name branch from 3c593b8 to baf754c Compare May 29, 2020 15:18
@ant-design-bot
Copy link
Contributor

ant-design-bot commented May 29, 2020

@afc163 afc163 merged commit c353e8b into ant-design:master May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants