Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Search autocomplele list in Chrome #26590

Merged
merged 3 commits into from Sep 4, 2020
Merged

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Sep 4, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #18808
close #7659
close #21965
close #19609

💡 Background and solution

See react-component/select#469

See here for more information about that issue.

In a nutshell for input fields which don't have the type="search" attribute the autocomplete popup is shown in Chromium based browsers. autocomplete="off" is not working anymore in Chromium. We have to use either autocomplete="new-password" (or any not existing autocomplete attribute) or type="search" which seems to be the better way.

It seems like the issue is much bigger than that: https://bugs.chromium.org/p/chromium/issues/detail?id=370363#c7

📝 Changelog

Language Changelog
🇺🇸 English Shutdown Select/TreeSelect autocomplete list in Chrome.
🇨🇳 Chinese 修复 Select/TreeSelect 在 Chrome 下出现原生自动完成列表的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Sep 4, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Sep 4, 2020

@codecov
Copy link

codecov bot commented Sep 4, 2020

Codecov Report

Merging #26590 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #26590   +/-   ##
=======================================
  Coverage   99.82%   99.82%           
=======================================
  Files         383      383           
  Lines        7347     7347           
  Branches     2007     2058   +51     
=======================================
  Hits         7334     7334           
  Misses         13       13           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a12a7ef...44b3b4c. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2020

Size Change: +238 B (0%)

Total Size: 800 kB

Filename Size Change
./dist/antd-with-locales.min.js 317 kB +11 B (0%)
./dist/antd.compact.min.css 66.2 kB +86 B (0%)
./dist/antd.dark.min.css 67.5 kB +49 B (0%)
./dist/antd.min.css 66.2 kB +85 B (0%)
./dist/antd.min.js 283 kB +7 B (0%)

compressed-size-action

@afc163 afc163 merged commit a8dea91 into master Sep 4, 2020
@afc163 afc163 deleted the fix-search-autocomplete branch September 4, 2020 16:38
@pr-triage pr-triage bot added the PR: merged label Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants