fix: added type=search to input component to prevent autocomplete to be shown in Chromium #469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/react-component/select/ox7ipxkmd |
mxschmitt
changed the title
|
any news on this? thanks |
|
Conflicting |
This does prevents the autocomplete window to be shown in Chromium based browsers See here for more information about that issue. ant-design/ant-design#18808
@afc163 updated the patch. |
afc163
added a commit
that referenced
this pull request
Sep 4, 2020
prevent autocomplete to be shown in Chromium close #469 close ant-design/ant-design#18808
Merged
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See here for more information about that issue.
In a nutshell for input fields which don't have the
type="search"attribute the autocomplete popup is shown in Chromium based browsers.autocomplete="off"is not working anymore in Chromium. We have to use eitherautocomplete="new-password"(or any not existing autocomplete attribute) ortype="search"which seems to be the better way.It seems like the issue is much bigger than that:
https://bugs.chromium.org/p/chromium/issues/detail?id=370363#c7