chore: 🆙 upgrade typescript-eslint #26600

afc163 · 2020-09-05T06:58:56Z

🤔 This is a ...

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language	Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

Doc is updated/provided or not needed
Demo is updated/provided or not needed
TypeScript definition is updated/provided or not needed
Changelog is provided or not needed

ant-design-bot · 2020-09-05T07:02:08Z

ant-design-bot · 2020-09-05T07:02:25Z

afc163 · 2020-09-05T07:07:16Z

/rebase

codesandbox-ci · 2020-09-05T07:08:28Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9d676eb:

Sandbox	Source
antd reproduction template	Configuration

github-actions · 2020-09-05T07:13:03Z

Size Change: -2 B (0%)

Total Size: 876 kB

Filename	Size	Change
`./dist/antd-with-locales.min.js`	355 kB	-2 B (0%)

ℹ️ View Unchanged

Filename	Size	Change
`./dist/antd.compact.min.css`	66.4 kB	0 B
`./dist/antd.dark.min.css`	67.6 kB	0 B
`./dist/antd.min.css`	66.4 kB	0 B
`./dist/antd.min.js`	321 kB	0 B

_{compressed-size-action}

afc163 · 2020-09-05T09:25:48Z

Need help to fix new eslint errors.

abenhamdine · 2020-09-05T10:23:14Z

I would recommend not upgrading to typescript-eslint 4 until these annoying false positives are fixed, see https://github.com/typescript-eslint/typescript-eslint/milestone/7

kerm1it · 2020-09-05T10:28:21Z

Obviously this isn't problem of code.

I think we can upgrade them when they are stable.

afc163 · 2020-09-07T07:57:43Z

/rebase

abenhamdine · 2020-09-08T07:06:41Z

For information, https://github.com/typescript-eslint/typescript-eslint/releases/tag/v4.1.0 has been released and fixes 90% of v4 false positives, but I still see a few remaining false positives in our own codebase at @Arhia.

yoyo837 · 2020-09-08T08:21:43Z

Need to continue to wait for version 4.1.1 or higher...

abenhamdine · 2020-09-10T10:16:28Z

Actually, community feedbacks show there more and more false positives detected, 4.X is definitely not currently usable.

hengkx · 2020-09-14T09:10:54Z

/rebase

afc163 · 2020-09-15T03:28:36Z

/rebase

hengkx · 2020-09-15T03:47:22Z

typescript-eslint/typescript-eslint#2540

afc163 · 2020-09-15T03:55:24Z

/rebase

…-design into typescript-eslint

hengkx · 2020-09-16T00:55:07Z

/rebase

hengkx · 2020-09-16T00:57:39Z

/rebase

hengkx · 2020-09-16T01:47:30Z

components/modal/confirm.tsx

@@ -33,7 +33,7 @@ export interface ModalStaticFunctions {
 export default function confirm(config: ModalFuncProps) {
  const div = document.createElement('div');
  document.body.appendChild(div);
-  // eslint-disable-next-line no-use-before-define
+  // eslint-disable-next-line @typescript-eslint/no-use-before-define
  let currentConfig = { ...config, close, visible: true } as any;


我也想知道 close 是从什么地方来的没看懂

window.close?

window.close?

不是，就是一个close的props

可以提到前面来：

ant-design/components/modal/confirm.tsx

Lines 78 to 85 in 9d676eb

function close(...args: any[]) {

currentConfig = {

...currentConfig,

visible: false,

afterClose: destroy.bind(this, ...args),

};

render(currentConfig);

}

window.close?

不是，就是一个close的props

根本没有定义。。。

看我的回复。

提不了吧互相引用了

hengkx · 2020-09-16T01:58:07Z

lint 终于过了🥳

codecov · 2020-09-16T01:59:00Z

Codecov Report

Merging #26600 into master will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #26600   +/-   ##
=======================================
  Coverage   99.82%   99.82%           
=======================================
  Files         384      384           
  Lines        7371     7371           
  Branches     2009     2050   +41     
=======================================
  Hits         7358     7358           
  Misses         13       13

Impacted Files	Coverage Δ
components/_util/type.ts	`100.00% <ø> (ø)`
components/anchor/Anchor.tsx	`100.00% <ø> (ø)`
components/avatar/index.tsx	`100.00% <ø> (ø)`
components/checkbox/Checkbox.tsx	`100.00% <ø> (ø)`
components/modal/confirm.tsx	`100.00% <ø> (ø)`
components/radio/index.tsx	`100.00% <ø> (ø)`
components/transfer/index.tsx	`100.00% <ø> (ø)`
components/auto-complete/index.tsx	`100.00% <100.00%> (ø)`
components/date-picker/generatePicker/index.tsx	`100.00% <100.00%> (ø)`
components/form/hooks/useForm.ts	`100.00% <100.00%> (ø)`
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0de1358...9d676eb. Read the comment docs.

afc163 · 2020-09-16T02:30:12Z

components/transfer/__tests__/index.test.js

@@ -1,4 +1,4 @@
-/* eslint no-use-before-define: "off" */
+/* eslint @typescript-eslint/no-use-before-define: "off" */


这个还需要么

yoyo837 · 2020-09-16T02:46:46Z

.eslintrc.js

@@ -121,6 +121,14 @@ module.exports = {
    'unicorn/prefer-trim-start-end': 2,
    'unicorn/expiring-todo-comments': 2,
    'unicorn/no-abusive-eslint-disable': 2,
+
+    // https://github.com/typescript-eslint/typescript-eslint/issues/2540#issuecomment-692866111
+    'no-use-before-define': 0,


为什么他们不通过覆盖config的方式来关闭，要用户自己配置呢？

我也不知道也没找到其它好的方案了，只能这样先干掉，看了下 ts 的确是正确的引用

github-actions bot force-pushed the typescript-eslint branch from 4c48930 to f84df00 Compare September 5, 2020 07:08

afc163 added the help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. label Sep 7, 2020

github-actions bot force-pushed the typescript-eslint branch from 2d3f4a1 to 53d34c7 Compare September 7, 2020 07:58

afc163 and others added 2 commits September 8, 2020 16:10

chore: 🆙 upgrade typescript-eslint

ee3032c

fix some lint

a88860d

fix: some eslint errors

4fdef30

afc163 force-pushed the typescript-eslint branch from e76337a to 4fdef30 Compare September 8, 2020 11:10

afc163 marked this pull request as draft September 10, 2020 07:25

Update package.json

65ce1c0

pr-triage bot added the PR: draft label Sep 15, 2020

afc163 and others added 4 commits September 15, 2020 03:29

chore: 🆙 upgrade typescript-eslint

6631c43

fix some lint

ff28476

fix: some eslint errors

94c4027

Update package.json

6a22ca3

github-actions bot force-pushed the typescript-eslint branch from 65ce1c0 to 6a22ca3 Compare September 15, 2020 03:29

hengkx added 2 commits September 16, 2020 08:54

fix no use before define

d99680c

Merge branch 'typescript-eslint' of https://github.com/ant-design/ant…

2417706

…-design into typescript-eslint

Update package.json

67e1d45

hengkx added 2 commits September 16, 2020 09:04

Merge branch 'master' into typescript-eslint

b878297

fix lint

9d676eb

hengkx reviewed Sep 16, 2020

View reviewed changes

hengkx marked this pull request as ready for review September 16, 2020 02:00

pr-triage bot added PR: unreviewed and removed PR: draft labels Sep 16, 2020

afc163 commented Sep 16, 2020

View reviewed changes

yoyo837 reviewed Sep 16, 2020

View reviewed changes

afc163 merged commit 481fd20 into master Sep 16, 2020

afc163 deleted the typescript-eslint branch September 16, 2020 03:43

pr-triage bot added PR: merged and removed PR: unreviewed labels Sep 16, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: 🆙 upgrade typescript-eslint #26600

chore: 🆙 upgrade typescript-eslint #26600

afc163 commented Sep 5, 2020 •

edited

ant-design-bot commented Sep 5, 2020 •

edited

ant-design-bot commented Sep 5, 2020 •

edited

afc163 commented Sep 5, 2020

codesandbox-ci bot commented Sep 5, 2020 •

edited

github-actions bot commented Sep 5, 2020 •

edited

afc163 commented Sep 5, 2020

abenhamdine commented Sep 5, 2020

kerm1it commented Sep 5, 2020 •

edited

afc163 commented Sep 7, 2020

abenhamdine commented Sep 8, 2020 •

edited

yoyo837 commented Sep 8, 2020

abenhamdine commented Sep 10, 2020

hengkx commented Sep 14, 2020

afc163 commented Sep 15, 2020

hengkx commented Sep 15, 2020 •

edited

afc163 commented Sep 15, 2020

hengkx commented Sep 16, 2020

hengkx commented Sep 16, 2020

hengkx Sep 16, 2020 •

edited

kerm1it Sep 16, 2020

yoyo837 Sep 16, 2020

afc163 Sep 16, 2020

hengkx Sep 16, 2020

afc163 Sep 16, 2020

hengkx Sep 16, 2020

hengkx commented Sep 16, 2020

codecov bot commented Sep 16, 2020 •

edited

afc163 Sep 16, 2020

hengkx Sep 16, 2020

yoyo837 Sep 16, 2020

hengkx Sep 16, 2020

	function close(...args: any[]) {
	currentConfig = {
	...currentConfig,
	visible: false,
	afterClose: destroy.bind(this, ...args),
	};
	render(currentConfig);
	}

		@@ -1,4 +1,4 @@
		/* eslint no-use-before-define: "off" */
		/* eslint @typescript-eslint/no-use-before-define: "off" */

chore: 🆙 upgrade typescript-eslint #26600

chore: 🆙 upgrade typescript-eslint #26600

Conversation

afc163 commented Sep 5, 2020 • edited

🤔 This is a ...

🔗 Related issue link

💡 Background and solution

📝 Changelog

☑️ Self Check before Merge

ant-design-bot commented Sep 5, 2020 • edited

ant-design-bot commented Sep 5, 2020 • edited

afc163 commented Sep 5, 2020

codesandbox-ci bot commented Sep 5, 2020 • edited

github-actions bot commented Sep 5, 2020 • edited

afc163 commented Sep 5, 2020

abenhamdine commented Sep 5, 2020

kerm1it commented Sep 5, 2020 • edited

afc163 commented Sep 7, 2020

abenhamdine commented Sep 8, 2020 • edited

yoyo837 commented Sep 8, 2020

abenhamdine commented Sep 10, 2020

hengkx commented Sep 14, 2020

afc163 commented Sep 15, 2020

hengkx commented Sep 15, 2020 • edited

afc163 commented Sep 15, 2020

hengkx commented Sep 16, 2020

hengkx commented Sep 16, 2020

hengkx Sep 16, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hengkx commented Sep 16, 2020

codecov bot commented Sep 16, 2020 • edited

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

afc163 commented Sep 5, 2020 •

edited

ant-design-bot commented Sep 5, 2020 •

edited

ant-design-bot commented Sep 5, 2020 •

edited

codesandbox-ci bot commented Sep 5, 2020 •

edited

github-actions bot commented Sep 5, 2020 •

edited

kerm1it commented Sep 5, 2020 •

edited

abenhamdine commented Sep 8, 2020 •

edited

hengkx commented Sep 15, 2020 •

edited

hengkx Sep 16, 2020 •

edited

codecov bot commented Sep 16, 2020 •

edited