-
-
Notifications
You must be signed in to change notification settings - Fork 47.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: 🆙 upgrade typescript-eslint #26600
Changes from all commits
ee3032c
a88860d
4fdef30
65ce1c0
6631c43
ff28476
94c4027
6a22ca3
d99680c
2417706
67e1d45
b878297
9d676eb
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -33,7 +33,7 @@ export interface ModalStaticFunctions { | |||||||||||||||||
export default function confirm(config: ModalFuncProps) { | ||||||||||||||||||
const div = document.createElement('div'); | ||||||||||||||||||
document.body.appendChild(div); | ||||||||||||||||||
// eslint-disable-next-line no-use-before-define | ||||||||||||||||||
// eslint-disable-next-line @typescript-eslint/no-use-before-define | ||||||||||||||||||
let currentConfig = { ...config, close, visible: true } as any; | ||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 我也想知道 close 是从什么地方 来的 没看懂 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. window.close? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
不是,就是一个close的props There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 可以提到前面来: ant-design/components/modal/confirm.tsx Lines 78 to 85 in 9d676eb
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
根本 没有 定义。。。 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 看我的回复。 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 提不了吧 互相 引用了 |
||||||||||||||||||
|
||||||||||||||||||
function destroy(...args: any[]) { | ||||||||||||||||||
|
@@ -47,7 +47,7 @@ export default function confirm(config: ModalFuncProps) { | |||||||||||||||||
} | ||||||||||||||||||
for (let i = 0; i < destroyFns.length; i++) { | ||||||||||||||||||
const fn = destroyFns[i]; | ||||||||||||||||||
// eslint-disable-next-line no-use-before-define | ||||||||||||||||||
// eslint-disable-next-line @typescript-eslint/no-use-before-define | ||||||||||||||||||
if (fn === close) { | ||||||||||||||||||
destroyFns.splice(i, 1); | ||||||||||||||||||
break; | ||||||||||||||||||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
import * as React from 'react'; | ||
import { | ||
GetRowKey, | ||
ColumnType as RcColumnType, | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
/* eslint no-use-before-define: "off" */ | ||
/* eslint @typescript-eslint/no-use-before-define: "off" */ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 这个还需要么 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 需要 |
||
import React from 'react'; | ||
import { render, mount } from 'enzyme'; | ||
import Transfer from '..'; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
为什么他们不通过覆盖config的方式来关闭,要用户自己配置呢?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我也不知道 也没 找到 其它 好的 方案了 ,只能 这样先 干掉,看了下 ts 的确 是正确的 引用