Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Divider border style not work on text mode #26863

Merged
merged 1 commit into from
Sep 23, 2020
Merged

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Sep 23, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

resolve #26846

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Divider border style not work when text is provided.
🇨🇳 Chinese 修复 Divider 在有文字时,设置边框颜色无效的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/divider/demo/customize-style.md

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Sep 23, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Sep 23, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 23, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ad3a0ec:

Sandbox Source
antd reproduction template Configuration
beautiful-kowalevski-zkke3 Issue #26846

@codecov
Copy link

codecov bot commented Sep 23, 2020

Codecov Report

Merging #26863 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #26863   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          384       384           
  Lines         7365      7365           
  Branches      2049      2007   -42     
=========================================
  Hits          7365      7365           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e03522...ad3a0ec. Read the comment docs.

@github-actions
Copy link
Contributor

Size Change: +46 B (0%)

Total Size: 796 kB

Filename Size Change
./dist/antd.compact.min.css 66.4 kB +13 B (0%)
./dist/antd.dark.min.css 67.7 kB +17 B (0%)
./dist/antd.min.css 66.4 kB +16 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd-with-locales.min.js 315 kB 0 B
./dist/antd.min.js 281 kB 0 B

compressed-size-action

@zombieJ zombieJ merged commit 1e176ed into master Sep 23, 2020
@zombieJ zombieJ deleted the fix-dividier branch September 23, 2020 05:33
@ycjcl868 ycjcl868 mentioned this pull request Sep 27, 2020
@afc163 afc163 mentioned this pull request Oct 13, 2020
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to set border color on divider component when it has text
2 participants