Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Avatar.Group add size props #27348

Merged
merged 2 commits into from
Oct 24, 2020
Merged

feat: Avatar.Group add size props #27348

merged 2 commits into from
Oct 24, 2020

Conversation

hengkx
Copy link
Member

@hengkx hengkx commented Oct 24, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#27068 #27138

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Avatar.Group add size props.
🇨🇳 Chinese Avatar.Group 增加 size 属性。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/avatar/demo/group.md
View rendered components/avatar/index.en-US.md
View rendered components/avatar/index.zh-CN.md

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Oct 24, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Oct 24, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 24, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ac7ec18:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Oct 24, 2020

Codecov Report

Merging #27348 into feature will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           feature    #27348   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          389       389           
  Lines         7399      7399           
  Branches      2082      2082           
=========================================
  Hits          7399      7399           
Impacted Files Coverage Δ
components/avatar/avatar.tsx 100.00% <ø> (ø)
components/avatar/group.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab4aeca...ac7ec18. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2020

Size Change: +25 B (0%)

Total Size: 792 kB

Filename Size Change
./dist/antd-with-locales.min.js 314 kB +11 B (0%)
./dist/antd.min.js 278 kB +14 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd.compact.min.css 66.4 kB 0 B
./dist/antd.dark.min.css 67.7 kB 0 B
./dist/antd.min.css 66.4 kB 0 B

compressed-size-action

@hengkx hengkx requested a review from xrkffgg October 24, 2020 13:22
@hengkx hengkx merged commit 6b1d73b into feature Oct 24, 2020
@hengkx hengkx deleted the avatar-group-size branch October 24, 2020 14:00
This was referenced Nov 2, 2020
07akioni pushed a commit that referenced this pull request Nov 7, 2020
* feat: Avatar.Group add size props

* change type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants