Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(📦): upgrade @ant-design/colors and remove rc-trigger from deps #27761

Merged
merged 5 commits into from
Nov 13, 2020

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Nov 13, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#22698

💡 Background and solution

  1. refactor(🆙): upgrade @ant-design/colors and fix test cases ant-design-icons#400
  2. perf(⬆️): unify rc-trigger version #27752

📝 Changelog

Language Changelog
🇺🇸 English Reduced 1kb bundle size by optimizing dependencies.
🇨🇳 Chinese 优化底层依赖降低打包体积。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@afc163 afc163 changed the title perf(📦): upgrade @ant-design/colors perf(📦): upgrade @ant-design/colors and remove rc-trigger from deps Nov 13, 2020
@ant-design-bot
Copy link
Contributor

ant-design-bot commented Nov 13, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 13, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 618c448:

Sandbox Source
antd reproduction template Configuration

@github-actions
Copy link
Contributor

github-actions bot commented Nov 13, 2020

Size Change: -11.3 kB (1%)

Total Size: 792 kB

Filename Size Change
./dist/antd-with-locales.min.js 314 kB -5.62 kB (1%)
./dist/antd.min.js 277 kB -5.71 kB (2%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd.compact.min.css 66.4 kB 0 B
./dist/antd.dark.min.css 67.8 kB 0 B
./dist/antd.min.css 66.5 kB 0 B

compressed-size-action

@codecov
Copy link

codecov bot commented Nov 13, 2020

Codecov Report

Merging #27761 (618c448) into master (d1d215e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #27761   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          390       390           
  Lines         7387      7387           
  Branches      2091      2084    -7     
=========================================
  Hits          7387      7387           
Impacted Files Coverage Δ
components/tooltip/index.tsx 100.00% <ø> (ø)
components/tooltip/placements.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1d215e...618c448. Read the comment docs.

@afc163 afc163 merged commit e7bed7c into master Nov 13, 2020
@afc163 afc163 deleted the upgrade-colors branch November 13, 2020 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants