Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: Alert rtl #28108

Merged
merged 6 commits into from
Dec 6, 2020
Merged

style: Alert rtl #28108

merged 6 commits into from
Dec 6, 2020

Conversation

jesse3mh9a
Copy link
Contributor

@jesse3mh9a jesse3mh9a commented Dec 1, 2020 •
edited by afc163
Loading

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Alert rtl style.
🇨🇳 Chinese 修复 Alert rtl 样式。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Dec 1, 2020 •
edited
Loading

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2020 •
edited
Loading

Size Change: -220 B (0%)

Total Size: 789 kB

Filename Size Change
./dist/antd.compact.min.css 66.7 kB -71 B (0%)
./dist/antd.dark.min.css 67.9 kB -79 B (0%)
./dist/antd.min.css 66.7 kB -70 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd-with-locales.min.js 313 kB 0 B
./dist/antd.min.js 275 kB 0 B

compressed-size-action

xrkffgg
xrkffgg reviewed Dec 1, 2020
View reviewed changes
components/alert/style/rtl.less Outdated
right: auto;
left: @padding-md;
margin-right: auto;
margin-left: 37px - 16 - @font-size-base;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为啥会有 37px - 数字的?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里主要是为了满足和上一版ui完全一致 算的
这里需要简单化处理吗? @afc163

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

他的意思是37px - 16会是非法值，是不是笔误？

@afc163
Copy link
Member

afc163 commented Dec 1, 2020

简化吧，建议按 index.less 里的样式完全重写一下。

@afc163
Copy link
Member

afc163 commented Dec 1, 2020

现在用了 flex，甚至直接 reverse 一下就行。

afc163
afc163 reviewed Dec 1, 2020
View reviewed changes
components/alert/style/index.less Outdated
@@ -111,7 +108,7 @@
}

&-with-description &-icon {
margin-right: @alert-with-description-padding-vertical;
margin-right: @margin-md;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个别动，担心有人覆盖过这个变量。

@jesse3mh9a
Copy link
Contributor Author

现在用了 flex，甚至直接 reverse 一下就行。
Accessibility concerns

reverse  这里和这个影响有关系吗? 如果没关系 是rtl 就简化多了

@afc163
Copy link
Member

afc163 commented Dec 1, 2020

reverse 这里和这个影响有关系吗? 如果没关系 是rtl 就简化多了

嗯，有 direction: rtl 就够了。

@jesse3mh9a
Copy link
Contributor Author

不使用 reverse 就现在这样吗

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 1, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 905bcf6:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Dec 1, 2020 •
edited
Loading

Codecov Report

Merging #28108 (d2bf37e) into master (76f724b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #28108   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          393       393           
  Lines         7388      7373   -15     
  Branches      2119      2112    -7     
=========================================
- Hits          7388      7373   -15
Impacted Files Coverage Δ
components/_util/wave.tsx 100.00% <0.00%> (ø)
components/button/button.tsx 100.00% <0.00%> (ø)
components/form/FormList.tsx 100.00% <0.00%> (ø)
components/tooltip/index.tsx 100.00% <0.00%> (ø)
components/button/LoadingIcon.tsx 100.00% <0.00%> (ø)
components/modal/useModal/index.tsx 100.00% <0.00%> (ø)
components/breadcrumb/BreadcrumbItem.tsx 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76f724b...905bcf6. Read the comment docs.

@afc163
Copy link
Member

afc163 commented Dec 5, 2020

Action 的位置左移了很多，请检查 https://www.argos-ci.com/ant-design/ant-design/builds/896

@jesse3mh9a
Copy link
Contributor Author

Action 的位置左移了很多，请检查 https://www.argos-ci.com/ant-design/ant-design/builds/896

有一处错误, 已经更改了.

@afc163 afc163 merged commit e097830 into ant-design:master Dec 6, 2020
@afc163 afc163 mentioned this pull request Dec 6, 2020
Merged
vouis pushed a commit to vouis/ant-design that referenced this pull request Dec 10, 2020
@jesse3mh9a @vouis
style: Alert rtl (ant-design#28108)
03adea7 
* style: Alert rtl

* update

* icon space

* update

* update

* fix
vouis pushed a commit to vouis/ant-design that referenced this pull request Dec 10, 2020
@jesse3mh9a @vouis
style: Alert rtl (ant-design#28108)
abf7fe7 
* style: Alert rtl

* update

* icon space

* update

* update

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afc163 afc163 afc163 left review comments

@yoyo837 yoyo837 yoyo837 left review comments

@xrkffgg xrkffgg xrkffgg left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jesse3mh9a @ant-design-bot @afc163 @yoyo837 @xrkffgg