Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(descriptions): children can be component that wraps DescriptionsItem #28785

Closed
wants to merge 3 commits into from

Conversation

kerm1it
Copy link
Member

@kerm1it kerm1it commented Jan 8, 2021

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #28254

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Children of Descriptions allow to be component that wraps Descriptions.Item.
🇨🇳 Chinese Descriptions 的子元素允许是包裹 Descriptions.Item 的组件。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@pr-triage pr-triage bot added the PR: draft label Jan 8, 2021
@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jan 8, 2021

@lgtm-com
Copy link

lgtm-com bot commented Jan 8, 2021

This pull request introduces 1 alert when merging 6524a01 into c53afea - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 8, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a6c0444:

Sandbox Source
antd reproduction template Configuration
带边框的 - antd@4.9.2 (forked) Issue #28254

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2021

Size Change: +251 B (0%)

Total Size: 787 kB

Filename Size Change
./dist/antd-with-locales.min.js 312 kB +127 B (0%)
./dist/antd.min.js 273 kB +124 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd.compact.min.css 66.9 kB 0 B
./dist/antd.dark.min.css 68.1 kB 0 B
./dist/antd.min.css 66.9 kB 0 B

compressed-size-action

@vVvlife
Copy link

vVvlife commented Jan 9, 2021

测试用例
这个是我之前写的一个用例,你看看合不合适,望指正

@kerm1it kerm1it marked this pull request as ready for review January 9, 2021 09:54
@kerm1it kerm1it changed the title chore(descriptions): child can be component that wrap DescriptionsItem chore(descriptions): children can be component that wraps DescriptionsItem Jan 9, 2021
Co-Authored-By: vVvlife <524376642@qq.com>
@kerm1it
Copy link
Member Author

kerm1it commented Jan 11, 2021

覆盖率怎么没了?

@kerm1it kerm1it closed this Jan 11, 2021
@kerm1it
Copy link
Member Author

kerm1it commented Jan 11, 2021

ref: #4853

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Descriptions描述列表嵌入子组件变成空白的问题
4 participants