Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Button pseudo-element (before) not adapting to the btn-border-width when loading #28886

Merged
merged 1 commit into from
Jan 16, 2021
Merged

fix: Button pseudo-element (before) not adapting to the btn-border-width when loading #28886

merged 1 commit into from
Jan 16, 2021

Conversation

jjanssen
Copy link
Contributor

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

Currently when setting a custom @btn-border-width the loading state does not take this into consideration (which is having a fixed -1px definition). Visually this causes the original color to show as an additional outline which does not show in the 1px state.

How it currently renders (3px as an example)

image

How I expect it to render

image

📝 Changelog

Language Changelog
🇺🇸 English Fix: Button pseudo-element (before) not adapting to the btn-border-width for its loading state
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jan 15, 2021

@github-actions
Copy link
Contributor

Size Change: 0 B

Total Size: 788 kB

ℹ️ View Unchanged
Filename Size Change
./dist/antd-with-locales.min.js 312 kB 0 B
./dist/antd.compact.min.css 66.9 kB 0 B
./dist/antd.dark.min.css 68.2 kB 0 B
./dist/antd.min.css 66.9 kB 0 B
./dist/antd.min.js 274 kB 0 B

compressed-size-action

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4f1e3a7:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Jan 15, 2021

Codecov Report

Merging #28886 (4f1e3a7) into master (0747b3c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #28886   +/-   ##
=======================================
  Coverage   99.98%   99.98%           
=======================================
  Files         393      393           
  Lines        7444     7444           
  Branches     2086     2086           
=======================================
  Hits         7443     7443           
  Misses          1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0747b3c...4f1e3a7. Read the comment docs.

@jjanssen jjanssen changed the title [FIX] Button pseudo-element (before) not adapting to the btn-border-width when loading fix: Button pseudo-element (before) not adapting to the btn-border-width when loading Jan 15, 2021
@afc163 afc163 merged commit 005627e into ant-design:master Jan 16, 2021
@ycjcl868 ycjcl868 mentioned this pull request Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants