Support override anchor default onClick scroll behavior by respect preventDefault #29188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #29188 +/- ##
===========================================
- Coverage 100.00% 99.98% -0.02%
===========================================
Files 393 394 +1
Lines 7466 7486 +20
Branches 2152 2142 -10
===========================================
+ Hits 7466 7485 +19
- Misses 0 1 +1
Continue to review full report at Codecov.
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit bbabf66:
|
|
Test case needed. |
|
ping @ulion |
|
Closing for no response, feel free to open a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
Anchor onClick handler does not respect preventDefault, currently it always call scrollTo. But, if the target anchor is hidden (e.g. collapsed), if I want to first expand it, then scroll to, currently there is no way to avoid the scrollTo jumping since AnchorLink always calls scrollTo after onClick, does not check whether the event isDefaultPrevented().
With this PR, now user can do their own logic in the onClick, without the default scrollTo behavior.
📝 Changelog
☑️ Self Check before Merge