Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation (and review) of docs/practice section #2998

Merged
merged 2 commits into from Sep 12, 2016
Merged

Translation (and review) of docs/practice section #2998

merged 2 commits into from Sep 12, 2016

Conversation

dxps
Copy link

@dxps dxps commented Sep 10, 2016

This is my translation of docs/practice section.
An additional review of a native chinese speaker may help.

@mention-bot
Copy link

@visvadw, thanks for your PR! By analyzing the annotation information on this pull request, we identified @afc163 and @benjycui to be potential reviewers

@dxps dxps mentioned this pull request Sep 10, 2016
53 tasks
@kvetoslavnovak
Copy link
Contributor

kvetoslavnovak commented Sep 10, 2016

Generally looks fine to me.

Some issues:

Localisation

In Code Text
Code examples still contain some Chinese texts. Here is my detail list. I do not have time for all changes so everyone is welcomed to help:

@benjycui
Copy link
Contributor

@kvetoslavnovak trace #1471

title: Cases
---

Ant Design is an implementation of UI Design Language。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ant Design is one design language for enterprise-like complex UIs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a is ok, this is not slogan.

@benjycui
Copy link
Contributor

@visvadw hope that my comments will help you to understand these documentation, thanks!

@benjycui
Copy link
Contributor

@afc163 产品名就这样翻译了么。。我看了那些网站,好像没有英文名。

@afc163
Copy link
Member

afc163 commented Sep 12, 2016

产品名翻译的都没啥问题。

comments/corrections included.
@dxps
Copy link
Author

dxps commented Sep 12, 2016

@benjycui Thanks for the corrections. 👍 I was sure that some parts were not correctly translated.
@afc163 Thanks also.

@benjycui benjycui merged commit a94ccc4 into ant-design:master Sep 12, 2016
@kvetoslavnovak
Copy link
Contributor

I have updated the issues list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants