Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: italic should not warning #31004

Merged
merged 2 commits into from
Jun 16, 2021
Merged

fix: italic should not warning #31004

merged 2 commits into from
Jun 16, 2021

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Jun 16, 2021

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

resolve #31002

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Typography warning for non-boolean attribute italic when italic config.
🇨🇳 Chinese 修复 Typography 配置 italic 时会警告不是一个合法 DOM 属性的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Jun 16, 2021

@codecov
Copy link

codecov bot commented Jun 16, 2021

Codecov Report

Merging #31004 (7285c27) into master (398b406) will not change coverage.
The diff coverage is n/a.

❗ Current head 7285c27 differs from pull request most recent head 8c43158. Consider uploading reports for the commit 8c43158 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##            master    #31004   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          397       397           
  Lines         7561      7561           
  Branches      2127      2127           
=========================================
  Hits          7561      7561           
Impacted Files Coverage Δ
components/typography/Base.tsx 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 398b406...8c43158. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 16, 2021

Size Change: +11 B (0%)

Total Size: 831 kB

Filename Size Change
./dist/antd-with-locales.min.js 341 kB +5 B (0%)
./dist/antd.min.js 297 kB +6 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd.compact.min.css 63.9 kB 0 B
./dist/antd.dark.min.css 65.2 kB 0 B
./dist/antd.min.css 64.1 kB 0 B

compressed-size-action

@afc163 afc163 merged commit b7bb7a5 into master Jun 16, 2021
@afc163 afc163 deleted the warning branch June 16, 2021 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using the "italic" attribute of "Text" will emit a warning!
2 participants