Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: BackTop should disappear when fade out #31357

Merged
merged 3 commits into from
Jul 12, 2021
Merged

fix: BackTop should disappear when fade out #31357

merged 3 commits into from
Jul 12, 2021

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Jul 12, 2021

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #31253

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix BackTop not disappear when fade out.
🇨🇳 Chinese 修复 BackTop 隐出后仍然可以交互的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Jul 12, 2021

@github-actions
Copy link
Contributor

github-actions bot commented Jul 12, 2021

Size Change: -46 B (0%)

Total Size: 832 kB

Filename Size Change
./dist/antd-with-locales.min.js 341 kB -23 B (0%)
./dist/antd.min.js 297 kB -23 B (0%)
ℹ️ View Unchanged
Filename Size
./dist/antd.compact.min.css 64.3 kB
./dist/antd.dark.min.css 65.6 kB
./dist/antd.min.css 64.4 kB

compressed-size-action

@codecov
Copy link

codecov bot commented Jul 12, 2021

Codecov Report

Merging #31357 (663df2a) into master (8022019) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #31357   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          397       397           
  Lines         7570      7567    -3     
  Branches      2134      2134           
=========================================
- Hits          7570      7567    -3     
Impacted Files Coverage Δ
components/form/ErrorList.tsx 100.00% <ø> (ø)
components/back-top/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8022019...663df2a. Read the comment docs.

@afc163 afc163 merged commit a145336 into master Jul 12, 2021
@afc163 afc163 deleted the fix-back-top branch July 12, 2021 11:25
@PeachScript PeachScript mentioned this pull request Jul 18, 2021
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Component BackTop Need to Destroy when Fade Leave
1 participant