refactor: picker full token #35615
Merged
refactor: picker full token #35615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Size Change: +294 B (0%) Total Size: 888 kB
ℹ️ View Unchanged
|
Codecov Report
@@ Coverage Diff @@
## next #35615 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 465 465
Lines 8470 8470
Branches 2401 2401
=========================================
Hits 8470 8470
Continue to review full report at Codecov.
|
zombieJ
reviewed
May 19, 2022
components/_util/theme/util/alias.ts
Outdated
| @@ -92,6 +92,7 @@ export default function formatToken(derivativeToken: RawMergedToken): AliasToken | |||
| colorSplit: 'rgba(0, 0, 0, 0.06)', | |||
| controlItemBgActive: primaryColors[0], | |||
| fontWeightStrong: 600, | |||
| fontWeight: 400, | |||
There was a problem hiding this comment.
感觉 fontWeight 400 像是一个固定值。感觉直接下面用到 400 的使用 normal 代替?
zombieJ
reviewed
May 19, 2022
components/calendar/style/index.tsx
Outdated
| yearSelectWidth: number; | ||
| monthSelectWidth: number; | ||
| miniContentHeight: number; | ||
| thHeight: number; |
zombieJ
reviewed
May 19, 2022
components/calendar/style/index.tsx
Outdated
| calendarFullPanelBg: string; | ||
| calendarItemActiveBg: string; | ||
| export interface ComponentToken { | ||
| yearSelectWidth: number; |
zombieJ
reviewed
May 19, 2022
| export interface ComponentToken { | ||
| yearSelectWidth: number; | ||
| monthSelectWidth: number; | ||
| miniContentHeight: number; |
zombieJ
reviewed
May 19, 2022
components/calendar/style/index.tsx
Outdated
| monthSelectWidth: number; | ||
| miniContentHeight: number; | ||
| thHeight: number; | ||
| dateValueHeight: number; |
There was a problem hiding this comment.
做成 PickerToken 然后用 controlHeightSM
zombieJ
reviewed
May 20, 2022
components/calendar/style/index.tsx
Outdated
| calendarItemActiveBg: token.controlItemBgActive, | ||
| dateValueHeight: token.controlHeightSM, | ||
| weekHeight: token.controlHeightSM * 0.75, | ||
| dateContentHeight: (token.fontSizeSM * token.lineHeights[0] + token.marginXS) * 3 + 2, |
There was a problem hiding this comment.
这个 lineHeight 可以抽一个 lineHeightSM 和 fontSizeSM 对应了。我们应该不能直接访问 lineHeights 才对
zombieJ
reviewed
May 20, 2022
| borderBlockEnd: 0, | ||
| borderInlineStart: 1.5, // FIXME: v4 magic | ||
| borderInlineEnd: 0, | ||
| borderBlockStartWidth: 1.5, // FIXME: v4 magic |
zombieJ
reviewed
May 20, 2022
| color: token.colorText, | ||
| lineHeight: '30px', // FIXME: v4 magic string | ||
| lineHeight: `${token.pickerPanelCellHeight + token.pickerCellPaddingVertical * 2}px`, |
There was a problem hiding this comment.
话说 th 是不是直接可以 vertical align 了？
zombieJ
approved these changes
May 20, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
☑️ Self Check before Merge