Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Select width getting smaller when search #41646

Merged
merged 6 commits into from Apr 7, 2023

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Apr 5, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close #27688
close #41530

💡 Background and solution

图片

关键改动:react-component/select#935

📝 Changelog

Language Changelog
🇺🇸 English Fix Select width becomes 0px when search after select something.
🇨🇳 Chinese 修复 Select 在搜索时宽度变为 0px 的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 370760a

Updated rc-select dependency to fix select component issues. This improved the usability and functionality of the select input in the ant-design library.

🔍 Walkthrough

🤖 Generated by Copilot at 370760a

  • Upgrade rc-select dependency to fix select component issues (link)

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2023

@afc163 afc163 changed the title chore: fix: Select width getting small when search Apr 5, 2023
@afc163 afc163 changed the title fix: Select width getting small when search fix: Select width getting smaller when search Apr 5, 2023
@socket-security
Copy link

socket-security bot commented Apr 7, 2023

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

⬆️ Updated Package Version Diff Added Capability Access +/- Transitive Count Publisher
@stackblitz/sdk@1.8.2 1.9.0...1.8.2 None +0/-0 fvsch

@afc163 afc163 marked this pull request as ready for review April 7, 2023 10:29
@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 281.45 KB
./dist/antd.min.css 66.28 KB (+5 B 🔺)
./dist/antd.dark.min.css 67.52 KB (+5 B 🔺)
./dist/antd.compact.min.css 66.23 KB (+5 B 🔺)
./dist/antd.variable.min.css 66.82 KB (+5 B 🔺)

@codecov
Copy link

codecov bot commented Apr 7, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (307b76b) 100.00% compared to head (e1ec199) 100.00%.

Additional details and impacted files
@@             Coverage Diff              @@
##           4.x-stable    #41646   +/-   ##
============================================
  Coverage      100.00%   100.00%           
============================================
  Files             450       450           
  Lines            8340      8340           
  Branches         2539      2539           
============================================
  Hits             8340      8340           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@afc163 afc163 merged commit 86ebf65 into 4.x-stable Apr 7, 2023
94 checks passed
@afc163 afc163 deleted the fix/select-width-when-search branch April 7, 2023 15:47
@afc163
Copy link
Member Author

afc163 commented Apr 7, 2023

master 等我明后天搞下

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants