Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Select width getting smaller when search #41722

Merged
merged 2 commits into from
Apr 10, 2023

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Apr 10, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close #27688
close #41530

💡 Background and solution

截屏2023-04-10 上午11 25 00

图片

关键改动:react-component/select#936

把 4.x 的改动挪到 5.x 上来:#41646

📝 Changelog

Language Changelog
🇺🇸 English Fix Select width becomes 0px when search after select something.
🇨🇳 Chinese 修复 Select 在搜索时宽度变为 0px 的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 370760a

Updated rc-select dependency to fix select component issues. This improved the usability and functionality of the select input in the ant-design library.

🔍 Walkthrough

🤖 Generated by Copilot at 370760a

  • Upgrade rc-select dependency to fix select component issues (link)

@github-actions
Copy link
Contributor

github-actions bot commented Apr 10, 2023

@afc163 afc163 changed the title bump rc-select fix: Select width become 0px when searching Apr 10, 2023
@afc163 afc163 changed the title fix: Select width become 0px when searching fix: Select width getting smaller when search Apr 10, 2023
@afc163 afc163 marked this pull request as ready for review April 10, 2023 03:42
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 375.8 KB (+7 B 🔺)
./dist/antd-with-locales.min.js 434.67 KB (+13 B 🔺)

@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (862ce2e) 100.00% compared to head (a016ff2) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #41722   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          614       614           
  Lines        10502     10515   +13     
  Branches      2875      2877    +2     
=========================================
+ Hits         10502     10515   +13     
Impacted Files Coverage Δ
components/select/style/single.tsx 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@afc163 afc163 merged commit 0eed438 into master Apr 10, 2023
@afc163 afc163 deleted the fix/select-width-when-search-antd-5 branch April 10, 2023 05:11
RedJue pushed a commit to RedJue/ant-design that referenced this pull request Apr 25, 2023
* bump rc-select

* fix: Select width become 0px when searching
RedJue pushed a commit to RedJue/ant-design that referenced this pull request Apr 25, 2023
* bump rc-select

* fix: Select width become 0px when searching
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants