chore: improved support for generics MenuItemType and MenuItemProps in the Menu component #42240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n the Menu component
|
|
|
related issue: #36065 |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #42240 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 619 618 -1
Lines 11048 10539 -509
Branches 3079 2879 -200
==========================================
- Hits 11048 10539 -509
☔ View full report in Codecov by Sentry. |
|
Could you add a typing test in |
added 3 commits
May 9, 2023 23:12
afc163
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
Fix: #36065
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at 83dbe46
Refactored
MenuandMenuItemcomponents to support custom menu item types and props as generic parameters. This allows users to create and use their own menu item types with additional props and callbacks.🔍 Walkthrough
🤖 Generated by Copilot at 83dbe46
ItemTypetype alias to support custom menu item types using generic parameter and conditional type (link)ItemTypeandMenuItemTypetypes fromuseItemshook module toMenucomponent module (link)CompoundedComponenttype alias to support custom props forMenucomponent using generic parameter and custom type aliases (link)GenericComponentinterface to extendCompoundedComponenttype and override call signature to accept generic props (link)Menucomponent toGenericComponenttype instead ofCompoundedComponenttype to export generic call signature and subcomponents (link)MenuItemcomponent to support custom props for different menu items using generic parameter and custom type alias (link)